Changeset 63168 in webkit


Ignore:
Timestamp:
Jul 12, 2010 10:10:10 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-07-12 Eric Seidel <​eric@webkit.org>

Reviewed by Sam Weinig.

Fix a typo in the adoption agency causing test failures
​https://bugs.webkit.org/show_bug.cgi?id=42133

  • html5lib/runner-expected-html5.txt:

2010-07-12 Eric Seidel <​eric@webkit.org>

Reviewed by Sam Weinig.

Fix a typo in the adoption agency causing test failures
​https://bugs.webkit.org/show_bug.cgi?id=42133

The new behavior actually differs from old webkit.
<p><b><p>TEST
was not bold in the old parser, but is bold now.
This matches Minefield and the HTML5 spec.

Covered by two tests in html5lib/runner.html.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r63165 r63168  
     12010-07-12  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Fix a typo in the adoption agency causing test failures
     6        https://bugs.webkit.org/show_bug.cgi?id=42133
     7
     8        * html5lib/runner-expected-html5.txt:
     9
    1102010-07-12  Adam Barth  <abarth@webkit.org>
    211

  • trunk/LayoutTests/html5lib/runner-expected-html5.txt

    r63135 r63168  
    99resources/tests1.dat:
    101030
    11 52
    12 53
    131178
    141280
    … …  
    5553|     <a>
    5654|       "Y"
    57 
    58 Test 52 of 113 in resources/tests1.dat failed. Input:
    59 <p id=a><b><p id=b></b>TEST
    60 Got:
    61 | <html>
    62 |   <head>
    63 |   <body>
    64 |     <p>
    65 |       id="a"
    66 |       <b>
    67 |     <p>
    68 |       id="b"
    69 |       <b>
    70 |         "TEST"
    71 Expected:
    72 | <html>
    73 |   <head>
    74 |   <body>
    75 |     <p>
    76 |       id="a"
    77 |       <b>
    78 |     <p>
    79 |       id="b"
    80 |       "TEST"
    81 
    82 Test 53 of 113 in resources/tests1.dat failed. Input:
    83 <b id=a><p><b id=b></p></b>TEST
    84 Got:
    85 | <html>
    86 |   <head>
    87 |   <body>
    88 |     <b>
    89 |       id="a"
    90 |       <p>
    91 |         <b>
    92 |           id="b"
    93 |       <b>
    94 |         "TEST"
    95 Expected:
    96 | <html>
    97 |   <head>
    98 |   <body>
    99 |     <b>
    100 |       id="a"
    101 |       <p>
    102 |         <b>
    103 |           id="b"
    104 |       "TEST"
    10555
    10656Test 78 of 113 in resources/tests1.dat failed. Input:

  • trunk/WebCore/ChangeLog

    r63166 r63168  
     12010-07-12  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Fix a typo in the adoption agency causing test failures
     6        https://bugs.webkit.org/show_bug.cgi?id=42133
     7
     8        The new behavior actually differs from old webkit.
     9        <p><b><p>TEST
     10        was not bold in the old parser, but is bold now.
     11        This matches Minefield and the HTML5 spec.
     12
     13        Covered by two tests in html5lib/runner.html.
     14
     15        * html/HTMLTreeBuilder.cpp:
     16        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
     17
    1182010-07-12  Pavel Feldman  <pfeldman@chromium.org>
    219

  • trunk/WebCore/html/HTMLTreeBuilder.cpp

    r63135 r63168  
    16311631        // 1.
    16321632        Element* formattingElement = m_tree.activeFormattingElements()->closestElementInScopeWithName(token.name());
    1633         if (!formattingElement || !m_tree.openElements()->inScope(formattingElement)) {
     1633        if (!formattingElement || (m_tree.openElements()->contains(formattingElement)) && !m_tree.openElements()->inScope(formattingElement)) {
    16341634            parseError(token);
    16351635            notImplemented(); // Check the stack of open elements for a more specific parse error.
Note: See TracChangeset for help on using the changeset viewer.