Changeset 63258 in webkit

Timestamp:

Jul 13, 2010 4:20:39 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-07-13 Chris Guillory <​chris.guillory@google.com>

Reviewed by David Levin.

Fix adoptRef usage violation in WebAccessibilityCacheImpl.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=42092

• src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::WeakHandle::create): (WebKit::WebAccessibilityCacheImpl::WeakHandle::WeakHandle):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebAccessibilityCacheImpl.cpp (modified) (2 diffs)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-07-13  Chris Guillory  <chris.guillory@google.com>
+
+        Reviewed by David Levin.
+
+        Fix adoptRef usage violation in WebAccessibilityCacheImpl.cpp.
+        https://bugs.webkit.org/show_bug.cgi?id=42092
+
+        * src/WebAccessibilityCacheImpl.cpp:
+        (WebKit::WebAccessibilityCacheImpl::WeakHandle::create):
+        (WebKit::WebAccessibilityCacheImpl::WeakHandle::WeakHandle):
+
 2010-07-13  Albert J. Wong  <ajwong@chromium.org>
 

trunk/WebKit/chromium/src/WebAccessibilityCacheImpl.cpp

@@ -65 +65 @@
 {
     // FIXME: Remove resetting ref-count from AccessibilityObjectWrapper
-    // and convert to use adoptRef.
-    return new WebAccessibilityCacheImpl::WeakHandle(object);
+    RefPtr<WebAccessibilityCacheImpl::WeakHandle> weakHandle = adoptRef(new WebAccessibilityCacheImpl::WeakHandle(object));
+    weakHandle->m_object->setWrapper(weakHandle.get());
+    
+    return weakHandle.release();
 }
 
@@ -72 +74 @@
     : AccessibilityObjectWrapper(object)
 {
-    m_object->setWrapper(this);
 }