Changeset 63315 in webkit

Timestamp:

Jul 14, 2010 6:57:48 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-07-14 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Invoke speech recognition when user clicks on the speech button of input elements.
​http://bugs.webkit.org/show_bug.cgi?id=42047

No new tests, the relevant LayoutTestController bindings will be added in a subsequent patch.

• rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): Added click handling. (WebCore::InputFieldSpeechButtonElement::speechInput): (WebCore::InputFieldSpeechButtonElement::recordingComplete): Callback to indicate recording progress. (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): Callback to receive recognized text. (WebCore::InputFieldSpeechButtonElement::detach):
• rendering/TextControlInnerElements.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/TextControlInnerElements.cpp (modified) (3 diffs)
• rendering/TextControlInnerElements.h (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-14  Satish Sampath  <satish@chromium.org>
+
+        Reviewed by Kent Tamura.
+
+        Invoke speech recognition when user clicks on the speech button of input elements.
+        http://bugs.webkit.org/show_bug.cgi?id=42047
+
+        No new tests, the relevant LayoutTestController bindings will be added in a subsequent patch.
+
+        * rendering/TextControlInnerElements.cpp:
+        (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
+        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): Added click handling.
+        (WebCore::InputFieldSpeechButtonElement::speechInput):
+        (WebCore::InputFieldSpeechButtonElement::recordingComplete): Callback to indicate recording progress.
+        (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): Callback to receive recognized text.
+        (WebCore::InputFieldSpeechButtonElement::detach):
+        * rendering/TextControlInnerElements.h:
+
 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/WebCore/rendering/TextControlInnerElements.cpp

@@ -37 +37 @@
 #include "HTMLTextAreaElement.h"
 #include "MouseEvent.h"
+#include "Page.h"
 #include "RenderLayer.h"
 #include "RenderTextControlSingleLine.h"
+#include "SpeechInput.h"
 
 namespace WebCore {
@@ -329 +331 @@
 inline InputFieldSpeechButtonElement::InputFieldSpeechButtonElement(Document* document)
     : TextControlInnerElement(document)
+    , m_capturing(false)
 {
 }
@@ -339 +342 @@
 void InputFieldSpeechButtonElement::defaultEventHandler(Event* event)
 {
-    // FIXME: Start speech recognition here.
-    HTMLDivElement::defaultEventHandler(event);
+    // On mouse down, select the text and set focus.
+    HTMLInputElement* input = static_cast<HTMLInputElement*>(shadowAncestorNode());
+    if (event->type() == eventNames().mousedownEvent && event->isMouseEvent() && static_cast<MouseEvent*>(event)->button() == LeftButton) {
+        if (renderer() && renderer()->visibleToHitTesting()) {
+            if (Frame* frame = document()->frame()) {
+                frame->eventHandler()->setCapturingMouseEventsNode(this);
+                m_capturing = true;
+            }
+        }
+        // The call to focus() below dispatches a focus event, and an event handler in the page might
+        // remove the input element from DOM. To make sure it remains valid until we finish our work
+        // here, we take a temporary reference.
+        RefPtr<HTMLInputElement> holdRef(input);
+        input->focus();
+        input->select();
+        event->setDefaultHandled();
+    }
+    // On mouse up, start speech recognition.
+    if (event->type() == eventNames().mouseupEvent && event->isMouseEvent() && static_cast<MouseEvent*>(event)->button() == LeftButton) {
+        if (m_capturing && renderer() && renderer()->visibleToHitTesting()) {
+            if (Frame* frame = document()->frame()) {
+                frame->eventHandler()->setCapturingMouseEventsNode(0);
+                m_capturing = false;
+            }
+            if (hovered()) {
+                speechInput()->startRecognition();
+                event->setDefaultHandled();
+            }
+        }
+    }
+
+    if (!event->defaultHandled())
+        HTMLDivElement::defaultEventHandler(event);
+}
+
+SpeechInput* InputFieldSpeechButtonElement::speechInput()
+{
+    if (!m_speechInput)
+        m_speechInput.set(new SpeechInput(document()->page()->speechInputClient(), this));
+    return m_speechInput.get();
+}
+
+void InputFieldSpeechButtonElement::recordingComplete()
+{
+    // FIXME: Add UI feedback here to indicate that audio recording stopped and recognition is
+    // in progress.
+}
+
+void InputFieldSpeechButtonElement::setRecognitionResult(const String& result)
+{
+    HTMLInputElement* input = static_cast<HTMLInputElement*>(shadowAncestorNode());
+    // The call to setValue() below dispatches an event, and an event handler in the page might
+    // remove the input element from DOM. To make sure it remains valid until we finish our work
+    // here, we take a temporary reference.
+    RefPtr<HTMLInputElement> holdRef(input);
+    input->setValue(result);
+    input->dispatchFormControlChangeEvent();
+    renderer()->repaint();
+}
+
+void InputFieldSpeechButtonElement::detach()
+{
+    if (m_capturing) {
+        if (Frame* frame = document()->frame())
+            frame->eventHandler()->setCapturingMouseEventsNode(0);      
+    }
+    TextControlInnerElement::detach();
 }
 

trunk/WebCore/rendering/TextControlInnerElements.h

@@ -29 +29 @@
 
 #include "HTMLDivElement.h"
+#include "SpeechInputListener.h"
 
 namespace WebCore {
 
+class SpeechInput;
 class String;
 
@@ -110 +112 @@
 #if ENABLE(INPUT_SPEECH)
 
-class InputFieldSpeechButtonElement : public TextControlInnerElement {
+class InputFieldSpeechButtonElement
+    : public TextControlInnerElement,
+      public SpeechInputListener {
 public:
     static PassRefPtr<InputFieldSpeechButtonElement> create(Document*);
@@ -116 +120 @@
     virtual void defaultEventHandler(Event*);
 
+    // SpeechInputListener methods.
+    void recordingComplete();
+    void setRecognitionResult(const String& result);
+
 private:
     InputFieldSpeechButtonElement(Document*);
+    virtual void detach();
+    SpeechInput* speechInput();
+
+    bool m_capturing;
+    OwnPtr<SpeechInput> m_speechInput;
 };