Changeset 63708 in webkit

Timestamp:

Jul 19, 2010 7:40:34 PM (14 years ago)

Author:

andersca@apple.com

Message:

WebKitTestRunner and WebProcess simultaneously stall in CoreIPC::Connection::sendOutgoingMessage
​https://bugs.webkit.org/show_bug.cgi?id=42356

Reviewed by Sam Weinig.

Up the port queue length from 5 to 1024. While this does solve the problem, we should still try to
make sendOutgoingMessage not block. I've filed ​https://bugs.webkit.org/show_bug.cgi?id=42611 to track
doing this on Mac and Windows.

• Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):
Call setMachPortQueueLength.

• Platform/mac/MachUtilities.cpp: Added.

(setMachPortQueueLength):
Given a mach port receive right, sets the port queue length.

• Platform/mac/MachUtilities.h: Added.

• WebKit2.xcodeproj/project.pbxproj:

Add MachUtilities.cpp and MachUtilities.h

Location:

trunk/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/CoreIPC/mac/ConnectionMac.cpp (modified) (2 diffs)
• Platform/mac/MachUtilities.cpp (added)
• Platform/mac/MachUtilities.h (added)
• WebKit2.xcodeproj/project.pbxproj (modified) (5 diffs)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-07-19  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Sam Weinig.
+
+        WebKitTestRunner and WebProcess simultaneously stall in CoreIPC::Connection::sendOutgoingMessage
+        https://bugs.webkit.org/show_bug.cgi?id=42356
+
+        Up the port queue length from 5 to 1024. While this does solve the problem, we should still try to
+        make sendOutgoingMessage not block. I've filed https://bugs.webkit.org/show_bug.cgi?id=42611 to track 
+        doing this on Mac and Windows.
+
+        * Platform/CoreIPC/mac/ConnectionMac.cpp:
+        (CoreIPC::Connection::open):
+        Call setMachPortQueueLength.
+
+        * Platform/mac/MachUtilities.cpp: Added.
+        (setMachPortQueueLength):
+        Given a mach port receive right, sets the port queue length.
+
+        * Platform/mac/MachUtilities.h: Added.
+        
+        * WebKit2.xcodeproj/project.pbxproj:
+        Add MachUtilities.cpp and MachUtilities.h
+
 2010-07-19  Anders Carlsson  <andersca@apple.com>
 

trunk/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp

@@ -28 +28 @@
 #include "CoreIPCMessageKinds.h"
 #include "MachPort.h"
+#include "MachUtilities.h"
 #include "RunLoop.h"
 #include <mach/vm_map.h>
@@ -92 +93 @@
     }
     
+    // Change the message queue length for the receive port.
+    setMachPortQueueLength(m_receivePort, MACH_PORT_QLIMIT_LARGE);
+
     // Register the data available handler.
     m_connectionQueue.registerMachPortEventHandler(m_receivePort, WorkQueue::MachPortDataAvailable, 

trunk/WebKit2/WebKit2.xcodeproj/project.pbxproj

@@ -38 +38 @@
                 1A2162B011F38971008AD0F5 /* NPRuntimeUtilities.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A2162AE11F38971008AD0F5 /* NPRuntimeUtilities.cpp */; };
                 1A2162B111F38971008AD0F5 /* NPRuntimeUtilities.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A2162AF11F38971008AD0F5 /* NPRuntimeUtilities.h */; };
+                1A24B5F211F531E800C38269 /* MachUtilities.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A24B5F011F531E800C38269 /* MachUtilities.cpp */; };
+                1A24B5F311F531E800C38269 /* MachUtilities.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A24B5F111F531E800C38269 /* MachUtilities.h */; };
                 1A30066E1110F4F70031937C /* ResponsivenessTimer.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A30066C1110F4F70031937C /* ResponsivenessTimer.h */; };
                 1A30EAC6115D7DA30053E937 /* ConnectionMac.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A30EAC5115D7DA30053E937 /* ConnectionMac.cpp */; };
@@ -308 +310 @@
                 1A2162AE11F38971008AD0F5 /* NPRuntimeUtilities.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = NPRuntimeUtilities.cpp; sourceTree = "<group>"; };
                 1A2162AF11F38971008AD0F5 /* NPRuntimeUtilities.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NPRuntimeUtilities.h; sourceTree = "<group>"; };
+                1A24B5F011F531E800C38269 /* MachUtilities.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MachUtilities.cpp; sourceTree = "<group>"; };
+                1A24B5F111F531E800C38269 /* MachUtilities.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MachUtilities.h; sourceTree = "<group>"; };
                 1A30066C1110F4F70031937C /* ResponsivenessTimer.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ResponsivenessTimer.h; sourceTree = "<group>"; };
                 1A30EAC5115D7DA30053E937 /* ConnectionMac.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ConnectionMac.cpp; sourceTree = "<group>"; };
@@ -700 +704 @@
                         isa = PBXGroup;
                         children = (
+                                1A24B5F011F531E800C38269 /* MachUtilities.cpp */,
+                                1A24B5F111F531E800C38269 /* MachUtilities.h */,
                                 BC0092F5115837A300E0AE2A /* RunLoopMac.mm */,
                                 BC0092F6115837A300E0AE2A /* WorkQueueMac.cpp */,
@@ -1252 +1258 @@
                                 1A2161B011F37664008AD0F5 /* NPJSObjectMap.h in Headers */,
                                 1A2162B111F38971008AD0F5 /* NPRuntimeUtilities.h in Headers */,
+                                1A24B5F311F531E800C38269 /* MachUtilities.h in Headers */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;
@@ -1445 +1452 @@
                                 1A2162B011F38971008AD0F5 /* NPRuntimeUtilities.cpp in Sources */,
                                 1A1C649B11F4174200553C19 /* WebContextMac.mm in Sources */,
+                                1A24B5F211F531E800C38269 /* MachUtilities.cpp in Sources */,
                         );
                         runOnlyForDeploymentPostprocessing = 0;