Changeset 63760 in webkit

Timestamp:

Jul 20, 2010 11:28:22 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-07-20 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

HTML5 tree builder should restore form state
​https://bugs.webkit.org/show_bug.cgi?id=42644

We need to tell self-closing tags that we're done parsing their
children. This patch fixes the following LayoutTests when run with
--html5-treebuilder:

fast/forms/button-state-restore.html
fast/forms/state-restore-to-non-autocomplete-form.html
fast/forms/state-restore-to-non-edited-controls.html
fast/history/saves-state-after-fragment-nav.html
http/tests/navigation/restore-form-state-https.html

• html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLConstructionSite.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-20  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        HTML5 tree builder should restore form state
+        https://bugs.webkit.org/show_bug.cgi?id=42644
+
+        We need to tell self-closing tags that we're done parsing their
+        children.  This patch fixes the following LayoutTests when run with
+        --html5-treebuilder:
+
+          fast/forms/button-state-restore.html
+          fast/forms/state-restore-to-non-autocomplete-form.html
+          fast/forms/state-restore-to-non-edited-controls.html
+          fast/history/saves-state-after-fragment-nav.html
+          http/tests/navigation/restore-form-state-https.html
+
+        * html/HTMLConstructionSite.cpp:
+        (WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
+
 2010-07-20  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/WebCore/html/HTMLConstructionSite.cpp

@@ -234 +234 @@
 {
     ASSERT(token.type() == HTMLToken::StartTag);
-    attachToCurrent(createHTMLElement(token));
+    RefPtr<Element> element = attachToCurrent(createHTMLElement(token));
+    // Normally HTMLElementStack is responsible for calling finishParsingChildren,
+    // but self-closing elements are never in the element stack so the stack
+    // doesn't get a chance to tell them that we're done parsing their children.
+    element->finishParsingChildren();
     // FIXME: Do we want to acknowledge the token's self-closing flag?
     // http://www.whatwg.org/specs/web-apps/current-work/multipage/tokenization.html#acknowledge-self-closing-flag