Changeset 63775 in webkit

Timestamp:

Jul 20, 2010 2:45:03 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-07-20 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Fix zoom in/out on EFL after r62666. The patch for adding viewport
missed the initialization of zoom_range.user_scalable. In case browser
doesn't care about the viewport and does not listen to the signal,
user_scalable will be always false, thus inhibiting zoom in/out.
​https://bugs.webkit.org/show_bug.cgi?id=42656

• efl/EWebLauncher/main.c: (on_viewport_changed): when listening to signal about viewport meta tag, it's not sufficient to receive the parameters. One needs also to enforce these parameters in WebKit.
• efl/ewk/ewk_view.cpp: (_ewk_view_priv_new): initialize user_scalable parameter to allow browser zooming in and out.

Location:

trunk/WebKit

Files:

• ChangeLog (modified) (1 diff)
• efl/EWebLauncher/main.c (modified) (1 diff)
• efl/ewk/ewk_view.cpp (modified) (1 diff)

trunk/WebKit/ChangeLog

@@ +1 @@
+2010-07-20  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Fix zoom in/out on EFL after r62666. The patch for adding viewport
+        missed the initialization of zoom_range.user_scalable. In case browser
+        doesn't care about the viewport and does not listen to the signal,
+        user_scalable will be always false, thus inhibiting zoom in/out.
+        https://bugs.webkit.org/show_bug.cgi?id=42656
+
+        * efl/EWebLauncher/main.c:
+        (on_viewport_changed): when listening to signal about viewport meta tag,
+        it's not sufficient to receive the parameters. One needs also to enforce
+        these parameters in WebKit.
+        * efl/ewk/ewk_view.cpp:
+        (_ewk_view_priv_new): initialize user_scalable parameter to allow
+        browser zooming in and out.
+
 2010-07-16  Zhe Su  <suzhe@chromium.org>
 

trunk/WebKit/efl/EWebLauncher/main.c

@@ -414 +414 @@
     app->viewport.maxScale = maxScale;
     app->viewport.userScalable = (Eina_Bool)userScalable;
+    viewport_set();
 }
 

trunk/WebKit/efl/ewk/ewk_view.cpp

@@ -596 +596 @@
     priv->settings.zoom_range.min_scale = ZOOM_MIN;
     priv->settings.zoom_range.max_scale = ZOOM_MAX;
+    priv->settings.zoom_range.user_scalable = EINA_TRUE;
 
     priv->main_frame = _ewk_view_core_frame_new(sd, priv, 0).get();