Changeset 63792 in webkit


Ignore:
Timestamp:
Jul 20, 2010 5:26:09 PM (14 years ago)
Author:
commit-queue@webkit.org
Message:

2010-07-20 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

prefetch categorization is exactly wrong
​https://bugs.webkit.org/show_bug.cgi?id=42651

The miscategorization caused onloads to issue early, so you see x,
y as 0, 0 in the buggy version.

  • fast/dom/HTMLLinkElement/onload-completion-test-expected.txt: Added.
  • fast/dom/HTMLLinkElement/onload-completion-test.html: Added.
  • fast/dom/HTMLLinkElement/resources: Added.
  • fast/dom/HTMLLinkElement/resources/nick.jpg: Added.

2010-07-20 Gavin Peters <​gavinp@chromium.org>

Reviewed by Adam Barth.

prefetch categorization is exactly wrong
​https://bugs.webkit.org/show_bug.cgi?id=42651

While I was in the area, I saw that CachedResource::schedule() was dead, so I have removed it.

Test: fast/dom/HTMLLinkElement/onload-completion-test.html

  • loader/CachedCSSStyleSheet.h:
  • loader/CachedFont.h:
  • loader/CachedImage.h:
  • loader/CachedResource.cpp:
  • loader/CachedResource.h: (WebCore::CachedResource::isPrefetch):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.h:
Location:
trunk
Files:
4 added
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r63791 r63792  
     12010-07-20  Gavin Peters  <gavinp@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        prefetch categorization is exactly wrong
     6        https://bugs.webkit.org/show_bug.cgi?id=42651
     7
     8        The miscategorization caused onloads to issue early, so you see x,
     9        y as 0, 0 in the buggy version.
     10
     11        * fast/dom/HTMLLinkElement/onload-completion-test-expected.txt: Added.
     12        * fast/dom/HTMLLinkElement/onload-completion-test.html: Added.
     13        * fast/dom/HTMLLinkElement/resources: Added.
     14        * fast/dom/HTMLLinkElement/resources/nick.jpg: Added.
     15
    1162010-07-20  Brian Weinstein  <bweinstein@apple.com>
    217

  • trunk/WebCore/ChangeLog

    r63786 r63792  
     12010-07-20  Gavin Peters  <gavinp@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        prefetch categorization is exactly wrong
     6        https://bugs.webkit.org/show_bug.cgi?id=42651
     7
     8        While I was in the area, I saw that CachedResource::schedule() was dead, so I have removed it.
     9
     10        Test: fast/dom/HTMLLinkElement/onload-completion-test.html
     11
     12        * loader/CachedCSSStyleSheet.h:
     13        * loader/CachedFont.h:
     14        * loader/CachedImage.h:
     15        * loader/CachedResource.cpp:
     16        * loader/CachedResource.h:
     17        (WebCore::CachedResource::isPrefetch):
     18        * loader/CachedScript.h:
     19        * loader/CachedXBLDocument.h:
     20        * loader/CachedXSLStyleSheet.h:
     21
    1222010-07-16  James Hawkins  <jhawkins@chromium.org>
    223

  • trunk/WebCore/loader/CachedCSSStyleSheet.h

    r52784 r63792  
    5252        virtual void error();
    5353
    54         virtual bool schedule() const { return true; }
    55 
    5654        void checkNotify();
    5755   

  • trunk/WebCore/loader/CachedFont.h

    r44749 r63792  
    5858    virtual void allClientsRemoved();
    5959
    60     virtual bool schedule() const { return true; }
    61 
    6260    void checkNotify();
    6361

  • trunk/WebCore/loader/CachedImage.h

    r59576 r63792  
    7171    bool httpStatusCodeErrorOccurred() const { return m_httpStatusCodeErrorOccurred; }
    7272   
    73     virtual bool schedule() const { return true; }
    74 
    7573    void checkNotify();
    7674   

  • trunk/WebCore/loader/CachedResource.cpp

    r63032 r63792  
    103103        m_docLoader->removeCachedResource(this);
    104104}
    105    
     105
    106106void CachedResource::load(DocLoader* docLoader, bool incremental, SecurityCheckPolicy securityCheck, bool sendResourceLoadCallbacks)
    107107{

  • trunk/WebCore/loader/CachedResource.h

    r63032 r63792  
    126126
    127127    virtual bool isImage() const { return false; }
     128    bool isPrefetch() const
     129    {
    128130#if ENABLE(LINK_PREFETCH)
    129     virtual bool isPrefetch() const { return type() != LinkPrefetch; }
     131        return type() == LinkPrefetch;
    130132#else
    131     virtual bool isPrefetch() const { return false; }
    132 #endif
     133        return false;
     134#endif
     135    }
    133136
    134137    unsigned accessCount() const { return m_accessCount; }
    … …  
    170173
    171174    bool isExpired() const;
    172 
    173     virtual bool schedule() const { return isPrefetch(); }
    174175
    175176    // List of acceptable MIME types separated by ",".

  • trunk/WebCore/loader/CachedScript.h

    r63273 r63792  
    4949        virtual void error();
    5050
    51         virtual bool schedule() const { return false; }
    52 
    5351        void checkNotify();
    5452

  • trunk/WebCore/loader/CachedXBLDocument.h

    r39556 r63792  
    5252        virtual void error();
    5353       
    54         virtual bool schedule() const { return true; }
    55        
    5654        void checkNotify();
    5755       

  • trunk/WebCore/loader/CachedXSLStyleSheet.h

    r44749 r63792  
    4949        virtual void error();
    5050       
    51         virtual bool schedule() const { return true; }
    52        
    5351        void checkNotify();
    5452       
Note: See TracChangeset for help on using the changeset viewer.