Changeset 63819 in webkit

Timestamp:

Jul 21, 2010 8:12:27 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-07-21 Mahesh Kulkarni <​mahesh.kulkarni@nokia.com>

Reviewed by Laszlo Gombos.

[QT] Leak and few more fixes to qt port of geolocation
​https://bugs.webkit.org/show_bug.cgi?id=42753

Fixes memory leak and default values set to attributes.

Memory leak fix no new test case added.

• platform/qt/GeolocationServiceQt.cpp: Added. (WebCore::GeolocationServiceQt::~GeolocationServiceQt): (WebCore::GeolocationServiceQt::positionUpdated):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/qt/GeolocationServiceQt.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-21  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
+
+        Reviewed by Laszlo Gombos.
+
+        [QT] Leak and few more fixes to qt port of geolocation
+        https://bugs.webkit.org/show_bug.cgi?id=42753
+
+        Fixes memory leak and default values set to attributes. 
+        
+        Memory leak fix no new test case added. 
+
+        * platform/qt/GeolocationServiceQt.cpp: Added.
+        (WebCore::GeolocationServiceQt::~GeolocationServiceQt):
+        (WebCore::GeolocationServiceQt::positionUpdated):
+
 2010-07-21  Kristian Amlie <kristian.amlie@nokia.com>
 

trunk/WebCore/platform/qt/GeolocationServiceQt.cpp

@@ -56 +56 @@
 GeolocationServiceQt::~GeolocationServiceQt()
 {
+    delete m_location;
 }
 
@@ -66 +67 @@
     double latitude = coord.latitude();
     double longitude = coord.longitude();
-    bool providesAltitude = true;
+    bool providesAltitude = (geoPosition.coordinate().type() == QGeoCoordinate::Coordinate3D);
     double altitude = coord.altitude();
 
-    double accuracy = geoPosition.hasAttribute(QGeoPositionInfo::HorizontalAccuracy) ?
-                        geoPosition.attribute(QGeoPositionInfo::HorizontalAccuracy) : 0.0;
+    double accuracy = geoPosition.attribute(QGeoPositionInfo::HorizontalAccuracy);
 
     bool providesAltitudeAccuracy = geoPosition.hasAttribute(QGeoPositionInfo::VerticalAccuracy);
-    double altitudeAccuracy = providesAltitudeAccuracy ? geoPosition.attribute(QGeoPositionInfo::VerticalAccuracy) : 0.0;
+    double altitudeAccuracy = geoPosition.attribute(QGeoPositionInfo::VerticalAccuracy);
 
     bool providesHeading =  geoPosition.hasAttribute(QGeoPositionInfo::Direction);
-    double heading = providesHeading ? geoPosition.attribute(QGeoPositionInfo::Direction) : 0.0;
+    double heading = geoPosition.attribute(QGeoPositionInfo::Direction);
 
     bool providesSpeed = geoPosition.hasAttribute(QGeoPositionInfo::GroundSpeed);
-    double speed = providesSpeed ? geoPosition.attribute(QGeoPositionInfo::GroundSpeed) : 0.0;
+    double speed = geoPosition.attribute(QGeoPositionInfo::GroundSpeed);
 
     RefPtr<Coordinates> coordinates = Coordinates::create(latitude, longitude, providesAltitude, altitude,