Changeset 63841 in webkit

Timestamp:

Jul 21, 2010 10:44:36 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-07-21 Finnur Thorarinsson <​finnur.webkit@gmail.com>

Reviewed by Dimitri Glazkov.

Avoid crashing during find-in-page when |view| is NULL.
​https://bugs.webkit.org/show_bug.cgi?id=42760

There are no layout tests because we don't have a repro case
to work with, so this is a speculative fix based on crash dump
diagnosis. See bug for details.

• src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::shouldScopeMatches):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebFrameImpl.cpp (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-07-21  Finnur Thorarinsson  <finnur.webkit@gmail.com>
+
+        Reviewed by Dimitri Glazkov.
+
+        Avoid crashing during find-in-page when |view| is NULL.
+        https://bugs.webkit.org/show_bug.cgi?id=42760
+        
+        There are no layout tests because we don't have a repro case
+        to work with, so this is a speculative fix based on crash dump
+        diagnosis. See bug for details.
+
+        * src/WebFrameImpl.cpp:
+        (WebKit::WebFrameImpl::shouldScopeMatches):
+
 2010-07-21  Hans Wennborg  <hans@chromium.org>
 

trunk/WebKit/chromium/src/WebFrameImpl.cpp

@@ -2102 +2102 @@
 bool WebFrameImpl::shouldScopeMatches(const String& searchText)
 {
-    // Don't scope if we can't find a frame or if the frame is not visible.
+    // Don't scope if we can't find a frame or a view or if the frame is not visible.
     // The user may have closed the tab/application, so abort.
-    if (!frame() || !hasVisibleContent())
+    if (!frame() || !frame()->view() || !hasVisibleContent())
         return false;