Changeset 63855 in webkit

Timestamp:

Jul 21, 2010 1:54:30 PM (14 years ago)

Author:

Adam Roben

Message:

Handle broken pipes in more places in CoreIPC

Fixes <​http://webkit.org/b/42784> Assertion failure in
Connection::readEventHandler when WebKitTestRunner exits

Reviewed by Anders Carlsson.

• Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::readEventHandler): Check for a broken pipe
whenever we call ::PeekNamedPipe.

Location:

trunk/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/CoreIPC/win/ConnectionWin.cpp (modified) (2 diffs)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-07-21  Adam Roben  <aroben@apple.com>
+
+        Handle broken pipes in more places in CoreIPC
+
+        Fixes <http://webkit.org/b/42784> Assertion failure in
+        Connection::readEventHandler when WebKitTestRunner exits
+
+        Reviewed by Anders Carlsson.
+
+        * Platform/CoreIPC/win/ConnectionWin.cpp:
+        (CoreIPC::Connection::readEventHandler): Check for a broken pipe
+        whenever we call ::PeekNamedPipe.
+
 2010-07-21  Adam Roben  <aroben@apple.com>
 

trunk/WebKit2/Platform/CoreIPC/win/ConnectionWin.cpp

@@ -125 +125 @@
                 if (!::PeekNamedPipe(m_connectionPipe, 0, 0, 0, 0, &bytesToRead)) {
                     DWORD error = ::GetLastError();
+                    if (error == ERROR_BROKEN_PIPE) {
+                        connectionDidClose();
+                        return;
+                    }
                     ASSERT_NOT_REACHED();
                     return;
@@ -175 +179 @@
         if (!::PeekNamedPipe(m_connectionPipe, 0, 0, 0, 0, &bytesToRead)) {
             DWORD error = ::GetLastError();
+            if (error == ERROR_BROKEN_PIPE) {
+                connectionDidClose();
+                return;
+            }
             ASSERT_NOT_REACHED();
         }