Changeset 63882 in webkit


Ignore:
Timestamp:
Jul 22, 2010 5:08:50 AM (14 years ago)
Author:
kent.hansen@nokia.com
Message:

2010-07-22 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Kent Tamura.

Error properties of the Global Object are missing the DontEnum attribute
​https://bugs.webkit.org/show_bug.cgi?id=28771

Add the attributes to become spec compliant.

  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):

2010-07-22 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Kent Tamura.

Error properties of the Global Object are missing the DontEnum attribute
​https://bugs.webkit.org/show_bug.cgi?id=28771

Update expected results for tests that now pass.

  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.2_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.3_T3-expected.txt:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/ChangeLog

    r63833 r63882  
     12010-07-22  Kent Hansen  <kent.hansen@nokia.com>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Error properties of the Global Object are missing the DontEnum attribute
     6        https://bugs.webkit.org/show_bug.cgi?id=28771
     7
     8        Add the attributes to become spec compliant.
     9
     10        * runtime/JSGlobalObject.cpp:
     11        (JSC::JSGlobalObject::reset):
     12
    1132010-07-20  Steve Falkenburg  <sfalken@apple.com>
    214

  • trunk/JavaScriptCore/runtime/JSGlobalObject.cpp

    r60392 r63882  
    292292    putDirectFunctionWithoutTransition(Identifier(exec, "RegExp"), d()->regExpConstructor, DontEnum);
    293293    putDirectFunctionWithoutTransition(Identifier(exec, "Error"), d()->errorConstructor, DontEnum);
    294     putDirectFunctionWithoutTransition(Identifier(exec, "EvalError"), d()->evalErrorConstructor);
    295     putDirectFunctionWithoutTransition(Identifier(exec, "RangeError"), d()->rangeErrorConstructor);
    296     putDirectFunctionWithoutTransition(Identifier(exec, "ReferenceError"), d()->referenceErrorConstructor);
    297     putDirectFunctionWithoutTransition(Identifier(exec, "SyntaxError"), d()->syntaxErrorConstructor);
    298     putDirectFunctionWithoutTransition(Identifier(exec, "TypeError"), d()->typeErrorConstructor);
    299     putDirectFunctionWithoutTransition(Identifier(exec, "URIError"), d()->URIErrorConstructor);
     294    putDirectFunctionWithoutTransition(Identifier(exec, "EvalError"), d()->evalErrorConstructor, DontEnum);
     295    putDirectFunctionWithoutTransition(Identifier(exec, "RangeError"), d()->rangeErrorConstructor, DontEnum);
     296    putDirectFunctionWithoutTransition(Identifier(exec, "ReferenceError"), d()->referenceErrorConstructor, DontEnum);
     297    putDirectFunctionWithoutTransition(Identifier(exec, "SyntaxError"), d()->syntaxErrorConstructor, DontEnum);
     298    putDirectFunctionWithoutTransition(Identifier(exec, "TypeError"), d()->typeErrorConstructor, DontEnum);
     299    putDirectFunctionWithoutTransition(Identifier(exec, "URIError"), d()->URIErrorConstructor, DontEnum);
    300300
    301301    // Set global values.

  • trunk/LayoutTests/ChangeLog

    r63880 r63882  
     12010-07-22  Kent Hansen  <kent.hansen@nokia.com>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Error properties of the Global Object are missing the DontEnum attribute
     6        https://bugs.webkit.org/show_bug.cgi?id=28771
     7
     8        Update expected results for tests that now pass.
     9
     10        * fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.1_T3-expected.txt:
     11        * fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.2_T3-expected.txt:
     12        * fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.3_T3-expected.txt:
     13
    1142010-07-22  Kent Hansen  <kent.hansen@nokia.com>
    215

  • trunk/LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.1_T3-expected.txt

    r58534 r63882  
    11S10.1.5_A2.1_T3
    22
    3 FAIL SputnikError: #1: 'EvalError' have attribute DontEnum
     3PASS
    44
    55TEST COMPLETE

  • trunk/LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.2_T3-expected.txt

    r58534 r63882  
    11S10.1.5_A2.2_T3
    22
    3 FAIL SputnikError: #1: 'EvalError' have attribute DontEnum
     3PASS
    44
    55TEST COMPLETE

  • trunk/LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.3_T3-expected.txt

    r58534 r63882  
    11S10.1.5_A2.3_T3
    22
    3 FAIL SputnikError: #1: 'EvalError' have attribute DontEnum
     3PASS
    44
    55TEST COMPLETE
Note: See TracChangeset for help on using the changeset viewer.