Changeset 63884 in webkit


Ignore:
Timestamp:
Jul 22, 2010 5:52:35 AM (14 years ago)
Author:
pfeldman@chromium.org
Message:

2010-07-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium Dev Tools: Separators are missing in the context menu.

​https://bugs.webkit.org/show_bug.cgi?id=42761

  • bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
  • platform/ContextMenuItem.h: (WebCore::):

2010-07-21 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium Dev Tools: Separators are missing in the context menu.

​https://bugs.webkit.org/show_bug.cgi?id=42761

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::populateCustomMenuItems):
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r63883 r63884  
     12010-07-21  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Yury Semikhatsky.
     4
     5        Chromium Dev Tools: Separators are missing in the context menu.
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=42761
     8
     9        * bindings/js/JSInspectorFrontendHostCustom.cpp:
     10        (WebCore::JSInspectorFrontendHost::showContextMenu):
     11        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
     12        (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
     13        * platform/ContextMenuItem.h:
     14        (WebCore::):
     15
    1162010-07-22  Zoltan Herczeg  <zherczeg@webkit.org>
    217

  • trunk/WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp

    r60392 r63884  
    9393        JSValue id = item->get(exec, Identifier(exec, "id"));
    9494        if (label.isUndefined() || id.isUndefined())
    95             items.append(new ContextMenuItem(SeparatorType, ContextMenuItemTagNoAction, String()));
     95            items.append(new ContextMenuItem(SeparatorType,
     96                                             ContextMenuItemCustomTagNoAction,
     97                                             String()));
    9698        else {
    9799            ContextMenuAction typedId = static_cast<ContextMenuAction>(ContextMenuItemBaseCustomTag + id.toInt32(exec));

  • trunk/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp

    r57073 r63884  
    8181        if (label->IsUndefined() || id->IsUndefined()) {
    8282          items.append(new ContextMenuItem(SeparatorType,
    83                                            ContextMenuItemTagNoAction,
     83                                           ContextMenuItemCustomTagNoAction,
    8484                                           String()));
    8585        } else {

  • trunk/WebCore/platform/ContextMenu.cpp

    r60882 r63884  
    816816#endif
    817817        case ContextMenuItemBaseCustomTag:
     818        case ContextMenuItemCustomTagNoAction:
     819        case ContextMenuItemLastCustomTag:
    818820        case ContextMenuItemBaseApplicationTag:
    819821            break;

  • trunk/WebCore/platform/ContextMenuItem.h

    r60454 r63884  
    145145#endif
    146146        ContextMenuItemBaseCustomTag = 5000,
     147        ContextMenuItemCustomTagNoAction = 5998,
     148        ContextMenuItemLastCustomTag = 5999,
    147149        ContextMenuItemBaseApplicationTag = 10000
    148150    };

  • trunk/WebKit/chromium/ChangeLog

    r63874 r63884  
     12010-07-21  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Reviewed by Yury Semikhatsky.
     4
     5        Chromium Dev Tools: Separators are missing in the context menu.
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=42761
     8
     9        * src/ContextMenuClientImpl.cpp:
     10        (WebKit::ContextMenuClientImpl::populateCustomMenuItems):
     11
    1122010-07-21  Kent Tamura  <tkent@chromium.org>
    213

  • trunk/WebKit/chromium/src/ContextMenuClientImpl.cpp

    r62743 r63884  
    278278    for (size_t i = 0; i < defaultMenu->itemCount(); ++i) {
    279279        ContextMenuItem* inputItem = defaultMenu->itemAtIndex(i, defaultMenu->platformDescription());
    280         if (inputItem->action() < ContextMenuItemBaseCustomTag || inputItem->action() >=  ContextMenuItemBaseApplicationTag)
     280        if (inputItem->action() < ContextMenuItemBaseCustomTag || inputItem->action() >  ContextMenuItemLastCustomTag)
    281281            continue;
    282282
Note: See TracChangeset for help on using the changeset viewer.