Changeset 63896 in webkit

Timestamp:

Jul 22, 2010 9:39:38 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-07-22 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Stop granting universal access to inspector front-end page.
​https://bugs.webkit.org/show_bug.cgi?id=42817

• inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::windowObjectCleared):

2010-07-22 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Stop granting universal access to inspector front-end page.
​https://bugs.webkit.org/show_bug.cgi?id=42817

• src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::frontendLoaded):

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/inspector/InspectorFrontendClientLocal.cpp (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/src/WebDevToolsFrontendImpl.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-22  Andrey Kosyakov  <caseq@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: Stop granting universal access to inspector front-end page.
+        https://bugs.webkit.org/show_bug.cgi?id=42817
+
+        * inspector/InspectorFrontendClientLocal.cpp:
+        (WebCore::InspectorFrontendClientLocal::windowObjectCleared):
+
 2010-07-22  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/WebCore/inspector/InspectorFrontendClientLocal.cpp

@@ -71 +71 @@
 void InspectorFrontendClientLocal::windowObjectCleared()
 {
-    // Grant the inspector the ability to script the inspected page.
-    m_frontendPage->mainFrame()->document()->securityOrigin()->grantUniversalAccess();
     // FIXME: don't keep reference to the script state
     m_frontendScriptState = scriptStateFromPage(debuggerWorld(), m_frontendPage);

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-07-22  Andrey Kosyakov  <caseq@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: Stop granting universal access to inspector front-end page.
+        https://bugs.webkit.org/show_bug.cgi?id=42817
+
+        * src/WebDevToolsFrontendImpl.cpp:
+        (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
+
 2010-07-22  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/WebKit/chromium/src/WebDevToolsFrontendImpl.cpp

@@ -151 +151 @@
     m_loaded = true;
 
-    // Grant the devtools page the ability to have source view iframes.
-    SecurityOrigin* origin = m_webViewImpl->page()->mainFrame()->domWindow()->securityOrigin();
-    origin->grantUniversalAccess();
-
     for (Vector<Vector<String> >::iterator it = m_pendingIncomingMessages.begin();
          it != m_pendingIncomingMessages.end();