Changeset 63943 in webkit

Timestamp:

Jul 22, 2010 7:36:02 PM (14 years ago)

Author:

morrita@google.com

Message:

2010-07-22 MORITA Hajime <​morrita@google.com>

Reviewed by Ojan Vafai.

Autoscroll on selection should take scrollbars into account as outside of the content.
​https://bugs.webkit.org/show_bug.cgi?id=40403

ScrollView's scroll-bar was considered as a part of content rect,
that prevents autoscroll to happen when the pointer is over the
scroll-bar. This change excluded scroll-bar region from scrolling
delta calculation.

Test: WebCore/manual-tests/autoscroll-over-scrollbar.html

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• manual-tests/autoscroll-over-scrollbar.html (added)
• rendering/RenderLayer.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-22  MORITA Hajime  <morrita@google.com>
+
+        Reviewed by Ojan Vafai.
+
+        Autoscroll on selection should take scrollbars into account as outside of the content.
+        https://bugs.webkit.org/show_bug.cgi?id=40403
+
+        ScrollView's scroll-bar was considered as a part of content rect,
+        that prevents autoscroll to happen when the pointer is over the
+        scroll-bar.  This change excluded scroll-bar region from scrolling
+        delta calculation.
+        
+        Test: WebCore/manual-tests/autoscroll-over-scrollbar.html
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::scrollRectToVisible):
+
 2010-07-22  Kent Tamura  <tkent@chromium.org>
 

trunk/WebCore/rendering/RenderLayer.cpp

@@ -1438 +1438 @@
                 newRect.setY(rect.y() - frameView->scrollY() + frameView->y());
             } else {
-                IntRect viewRect = frameView->visibleContentRect(true);
+                IntRect viewRect = frameView->visibleContentRect();
                 IntRect r = getRectToExpose(viewRect, rect, alignX, alignY);