Changeset 63962 in webkit

Timestamp:

Jul 23, 2010 4:58:54 AM (14 years ago)

Author:

yurys@chromium.org

Message:

2010-07-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: error info propagation in InspectorBackendDispatch should be improved
​https://bugs.webkit.org/show_bug.cgi?id=42873

• inspector/CodeGeneratorInspector.pm: report wrong parameter count and wrong parametere type errror to the dispatch method caller

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/CodeGeneratorInspector.pm (modified) (5 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-23  Yury Semikhatsky  <yurys@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: error info propagation in InspectorBackendDispatch should be improved
+        https://bugs.webkit.org/show_bug.cgi?id=42873
+
+        * inspector/CodeGeneratorInspector.pm: report wrong parameter count and wrong
+        parametere type errror to the dispatch method caller
+
 2010-07-23  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/WebCore/inspector/CodeGeneratorInspector.pm

@@ -173 +173 @@
     $backendTypes{"Array"} = 1;
 
+    generateBackendPrivateFunctions();
     generateFunctions($interface);
 }
@@ -223 +224 @@
 }
 
+sub generateBackendPrivateFunctions
+{
+    my $privateFunctions = << "EOF";
+static String formatWrongArgumentsCountMessage(unsigned expected, unsigned actual)
+{
+    return String::format(\"Wrong number of parameters: %d (expected: %d)\", actual, expected);
+}
+
+static String formatWrongArgumentTypeMessage(unsigned position, const char* name, const char* expectedType)
+{
+    return String::format(\"Failed to convert parameter %d (%s) to %s\", position, name, expectedType);
+}
+EOF
+    push(@backendMethodsImpl, $privateFunctions);
+}
+
 sub generateBackendFunction
 {
@@ -234 +251 @@
     my $arguments = join(", ", map($typeTransform{$_->type}->{"param"} . " " . $_->name, @argsFiltered));
 
-    my $signature = "    void ${functionName}(PassRefPtr<InspectorArray> args);";
+    my $signature = "    void ${functionName}(PassRefPtr<InspectorArray> args, String* exception);";
     !$backendMethods{${signature}} || die "Duplicate function was detected for signature '$signature'.";
     $backendMethods{${signature}} = $functionName;
 
     my @function;
-    # Skip parameter name if no arguments in the array. Just to avoid unused parameter warning.
-    push(@function, "void ${backendClassName}::${functionName}(PassRefPtr<InspectorArray>" . ( scalar(@argsFiltered) ? " args)" : ")"));
+    push(@function, "void ${backendClassName}::${functionName}(PassRefPtr<InspectorArray> args, String* exception)");
     push(@function, "{");
     my $i = 1; # zero element is the method name.
+    my $expectedParametersCount = scalar(@argsFiltered);
+    push(@function, "    if (args->length() != $expectedParametersCount) {");
+    push(@function, "        *exception = formatWrongArgumentsCountMessage(args->length(), $expectedParametersCount);");
+    push(@function, "        ASSERT_NOT_REACHED();");
+    push(@function, "        return;");
+    push(@function, "    }");
+
     foreach my $parameter (@argsFiltered) {
-        push(@function, "    " . $typeTransform{$parameter->type}->{"retVal"} . " " . $parameter->name . ";");
-        push(@function, "    if (!args->get(" . $i . ")->as" . $typeTransform{$parameter->type}->{"accessorSuffix"} . "(&" . $parameter->name . ")) {");
+        my $parameterType = $parameter->type;
+        push(@function, "    " . $typeTransform{$parameterType}->{"retVal"} . " " . $parameter->name . ";");
+        push(@function, "    if (!args->get(" . $i . ")->as" . $typeTransform{$parameterType}->{"accessorSuffix"} . "(&" . $parameter->name . ")) {");
+        push(@function, "        *exception = formatWrongArgumentTypeMessage($i, \"" . $parameter->name . "\", \"$parameterType\");");
         push(@function, "        ASSERT_NOT_REACHED();");
         push(@function, "        return;");
@@ -265 +290 @@
     push(@body, "void ${backendClassName}::dispatch(const String& message, String* exception)");
     push(@body, "{");
-    push(@body, "    typedef void (${backendClassName}::*CallHandler)(PassRefPtr<InspectorArray> args);");
+    push(@body, "    typedef void (${backendClassName}::*CallHandler)(PassRefPtr<InspectorArray> args, String* exception);");
     push(@body, "    typedef HashMap<String, CallHandler> DispatchMap;");
     push(@body, "    DEFINE_STATIC_LOCAL(DispatchMap, dispatchMap, );");
@@ -302 +327 @@
     push(@body, "    if (it == dispatchMap.end()) {");
     push(@body, "        ASSERT_NOT_REACHED();");
-    push(@body, "        String::format(\"Error: Invalid method name. '%s' wasn't found.\", methodName.utf8().data());");
+    push(@body, "        *exception = String::format(\"Error: Invalid method name. '%s' wasn't found.\", methodName.utf8().data());");
     push(@body, "        return;");
     push(@body, "    }");
     push(@body, "");
-    push(@body, "    ((*this).*it->second)(messageArray);");
+    push(@body, "    ((*this).*it->second)(messageArray, exception);");
     push(@body, "}");
     return @body;