Changeset 64011 in webkit


Ignore:
Timestamp:
Jul 24, 2010 11:48:42 AM (14 years ago)
Author:
andreas.kling@nokia.com
Message:

2010-07-24 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] tst_QWebFrame::callQtInvokable() fails
https://bugs.webkit.org/show_bug.cgi?id=41065

Converting JS objects to QVariantMaps was broken.
This is a partial revert of <http://trac.webkit.org/changeset/61478>

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): Remove erroneous crash guard around JSObject::getPropertyNames()
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r64010 r64011  
     12010-07-24  Andreas Kling  <andreas.kling@nokia.com>
     2
     3        Reviewed by Simon Hausmann.
     4
     5        [Qt] tst_QWebFrame::callQtInvokable() fails
     6        https://bugs.webkit.org/show_bug.cgi?id=41065
     7
     8        Converting JS objects to QVariantMaps was broken.
     9        This is a partial revert of <http://trac.webkit.org/changeset/61478>
     10
     11        * bridge/qt/qt_runtime.cpp:
     12        (JSC::Bindings::convertValueToQVariant): Remove erroneous crash guard
     13        around JSObject::getPropertyNames()
     14
    1152010-07-24  Adam Barth  <abarth@webkit.org>
    216
  • trunk/WebCore/bridge/qt/qt_runtime.cpp

    r63660 r64011  
    339339                // Enumerate the contents of the object
    340340                PropertyNameArray properties(exec);
    341                 if (properties.size() > 0)
    342                     object->getPropertyNames(exec, properties);
     341                object->getPropertyNames(exec, properties);
    343342                PropertyNameArray::const_iterator it = properties.begin();
    344343
Note: See TracChangeset for help on using the changeset viewer.