Changeset 64033 in webkit


Ignore:
Timestamp:
Jul 25, 2010 11:57:55 PM (14 years ago)
Author:
Darin Adler
Message:

2010-07-25 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
​https://bugs.webkit.org/show_bug.cgi?id=42326

  • platform/mac-wk2/Skipped: Removed all the tests from the list that were there only because they called dumpSelectionRect. Most of them pass now.

2010-07-25 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
​https://bugs.webkit.org/show_bug.cgi?id=42326

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpSelectionRect.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this does nothing because its purpose is to change pixel test output and we do not have pixel tests implemented yet.
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r64032 r64033  
     12010-07-25  Darin Adler  <darin@apple.com>
     2
     3        Reviewed by Dan Bernstein.
     4
     5        WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
     6        https://bugs.webkit.org/show_bug.cgi?id=42326
     7
     8        * platform/mac-wk2/Skipped: Removed all the tests from the list
     9        that were there only because they called dumpSelectionRect. Most of
     10        them pass now.
     11
    1122010-07-23  Philippe Normand  <pnormand@igalia.com>
    213

  • trunk/LayoutTests/platform/mac-wk2/Skipped

    r64030 r64033  
    17801780webarchive/test-xml-stylesheet.xml
    17811781
    1782 # WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
    1783 # <https://bugs.webkit.org/show_bug.cgi?id=42326>
    1784 svg/text/foreignObject-text-clipping-bug.xml
    1785 svg/text/text-align-01-b.svg
    1786 svg/text/text-align-02-b.svg
    1787 svg/text/text-align-03-b.svg
    1788 svg/text/text-align-04-b.svg
    1789 svg/text/text-align-05-b.svg
    1790 svg/text/text-align-06-b.svg
    1791 svg/text/text-altglyph-01-b.svg
    1792 svg/text/text-deco-01-b.svg
    1793 svg/text/text-fonts-01-t.svg
    1794 svg/text/text-fonts-02-t.svg
    1795 svg/text/text-intro-05-t.svg
    1796 svg/text/text-path-01-b.svg
    1797 svg/text/text-spacing-01-b.svg
    1798 svg/text/text-text-01-b.svg
    1799 svg/text/text-text-03-b.svg
    1800 svg/text/text-text-04-t.svg
    1801 svg/text/text-text-05-t.svg
    1802 svg/text/text-text-06-t.svg
    1803 svg/text/text-text-07-t.svg
    1804 svg/text/text-text-08-b.svg
    1805 svg/text/text-tref-01-b.svg
    1806 svg/text/text-tselect-01-b.svg
    1807 svg/text/text-tselect-02-f.svg
    1808 svg/text/text-tspan-01-b.svg
    1809 svg/text/text-ws-01-t.svg
    1810 svg/text/text-ws-02-t.svg
    1811 svg/text/textPathBoundsBug.svg
    1812 
    18131782# WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
    18141783# <https://bugs.webkit.org/show_bug.cgi?id=42327>

  • trunk/WebKitTools/ChangeLog

    r64029 r64033  
     12010-07-25  Darin Adler  <darin@apple.com>
     2
     3        Reviewed by Dan Bernstein.
     4
     5        WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
     6        https://bugs.webkit.org/show_bug.cgi?id=42326
     7
     8        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
     9        Added dumpSelectionRect.
     10
     11        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
     12        (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
     13        does nothing because its purpose is to change pixel test output and
     14        we do not have pixel tests implemented yet.
     15
    1162010-07-25  Darin Adler  <darin@apple.com>
    217

  • trunk/WebKitTools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl

    r64029 r64033  
    3636        void dumpChildFrameScrollPositions();
    3737        void dumpEditingCallbacks();
     38        void dumpSelectionRect();
    3839        void dumpStatusCallbacks();
    3940

  • trunk/WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.h

    r64029 r64033  
    5454    void dumpChildFrameScrollPositions() { m_shouldDumpAllFrameScrollPositions = true; }
    5555    void dumpEditingCallbacks() { m_dumpEditingCallbacks = true; }
     56    void dumpSelectionRect() { } // Will need to do something when we support pixel tests.
    5657    void dumpStatusCallbacks() { m_dumpStatusCallbacks = true; }
    5758
Note: See TracChangeset for help on using the changeset viewer.