Changeset 64071 in webkit

Timestamp:

Jul 26, 2010 1:53:02 PM (14 years ago)

Author:

mrowe@apple.com

Message:

<​http://webkit.org/b/42990> REGRESSION (r63854): Safari RSS layout is broken due to changes in vendor prefix handling

Reviewed by Dan Bernstein.

In r63854 support for properties with the -khtml vendor prefix was removed. This breaks the layout of
Safari's RSS interface, several Dashboard widgets that are included with Mac OS X, and at least one
popular third-party Mac OS X application. This change will need to be revisited in a manner that has
a clearer backwards-compatibility strategy. <​http://webkit.org/b/42093> will be reopened to track that.

• css/CSSParser.cpp:

(WebCore::cssPropertyID): Revert the WebCore change from r63854.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSParser.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-26  Mark Rowe  <mrowe@apple.com>
+
+        Reviewed by Dan Bernstein.
+
+        <http://webkit.org/b/42990> REGRESSION (r63854): Safari RSS layout is broken due to changes in vendor prefix handling
+
+        In r63854 support for properties with the -khtml vendor prefix was removed. This breaks the layout of
+        Safari's RSS interface, several Dashboard widgets that are included with Mac OS X, and at least one
+        popular third-party Mac OS X application. This change will need to be revisited in a manner that has
+        a clearer backwards-compatibility strategy. <http://webkit.org/b/42093> will be reopened to track that.
+
+        * css/CSSParser.cpp:
+        (WebCore::cssPropertyID): Revert the WebCore change from r63854.
+
 2010-07-26  Brady Eidson  <beidson@apple.com>
 

trunk/WebCore/css/CSSParser.cpp

@@ -5611 +5611 @@
     const char* name = buffer;
     if (buffer[0] == '-') {
-        if (!strcmp(buffer, "-apple-dashboard-region") || !strcmp(buffer, "-apple-line-clamp")) {
-            // Support two Apple-specific CSS properties previously used for
-            // the Dashboard and Safari RSS line clamping.
+        // If the prefix is -apple- or -khtml-, change it to -webkit-.
+        // This makes the string one character longer.
+        if (hasPrefix(buffer, length, "-apple-") || hasPrefix(buffer, length, "-khtml-")) {
             memmove(buffer + 7, buffer + 6, length + 1 - 6);
             memcpy(buffer, "-webkit", 7);
             ++length;
-        } else if (!strcmp(buffer, "-webkit-opacity")) {
-            // Honor -webkit-opacity as a synonym for opacity. This was the only
-            // syntax that worked in Safari 1.1, and may be in use on some websites and widgets.
-            const char* const opacity = "opacity";
-            name = opacity;
-            length = 7;
-        } else if (hasPrefix(buffer, length, "-webkit-border-")) {
-            // -webkit-border-*-*-radius worked in Safari 4 and earlier. -webkit-border-radius syntax
-            // differs from border-radius, so it remains as a distinct property.
-            if (!strcmp(buffer + 15, "top-left-radius")
-                    || !strcmp(buffer + 15, "top-right-radius")
-                    || !strcmp(buffer + 15, "bottom-right-radius")
-                    || !strcmp(buffer + 15, "bottom-left-radius")) {
-                name = buffer + 8;
-                length -= 8;
+        }
+
+        if (hasPrefix(buffer, length, "-webkit")) {
+            if (strcmp(buffer, "-webkit-opacity") == 0) {
+                // Honor -webkit-opacity as a synonym for opacity.
+                // This was the only syntax that worked in Safari 1.1, and may be in use on some websites and widgets.
+                const char* const opacity = "opacity";
+                name = opacity;
+                length = strlen(opacity);
+            } else if (hasPrefix(buffer + 7, length - 7, "-border-")) {
+                // -webkit-border-*-*-radius worked in Safari 4 and earlier. -webkit-border-radius syntax
+                // differs from border-radius, so it is remains as a distinct property.
+                if (!strcmp(buffer + 15, "top-left-radius")
+                        || !strcmp(buffer + 15, "top-right-radius")
+                        || !strcmp(buffer + 15, "bottom-right-radius")
+                        || !strcmp(buffer + 15, "bottom-left-radius")) {
+                    name = buffer + 8;
+                    length -= 8;
+                }
             }
         }