Changeset 64132 in webkit

Timestamp:

Jul 27, 2010 9:06:48 AM (14 years ago)

Author:

Adam Roben

Message:

Add a ProcessDidExit callback to the WKPageLoaderClient

Fixes <​http://webkit.org/b/43048> UI process needs a way to find out
when the web process crashes

Reviewed by Anders Carlsson.

• UIProcess/API/C/WKPage.h: Added WKPageProcessDidExitCallback, and a

processDidExit member of that type to WKPageLoaderClient.

• UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::processDidExit): Added. Calls through to the
WKPageLoaderClient.

• UIProcess/WebLoaderClient.h: Added processDidExit.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidExit): Tell the loader client the
process exited.

Location:

trunk/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/C/WKPage.h (modified) (2 diffs)
• UIProcess/WebLoaderClient.cpp (modified) (1 diff)
• UIProcess/WebLoaderClient.h (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-07-27  Adam Roben  <aroben@apple.com>
+
+        Add a ProcessDidExit callback to the WKPageLoaderClient
+
+        Fixes <http://webkit.org/b/43048> UI process needs a way to find out
+        when the web process crashes
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/API/C/WKPage.h: Added WKPageProcessDidExitCallback, and a
+        processDidExit member of that type to WKPageLoaderClient.
+
+        * UIProcess/WebLoaderClient.cpp:
+        (WebKit::WebLoaderClient::processDidExit): Added. Calls through to the
+        WKPageLoaderClient.
+
+        * UIProcess/WebLoaderClient.h: Added processDidExit.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::processDidExit): Tell the loader client the
+        process exited.
+
 2010-07-27  Andras Becsi  <abecsi@webkit.org>
 

trunk/WebKit2/UIProcess/API/C/WKPage.h

@@ -66 +66 @@
 
 // WebPageNamespace Client
-// FIXME: These two methods should not be part of this client.
+// FIXME: These three functions should not be part of this client.
 typedef void (*WKPageDidBecomeUnresponsiveCallback)(WKPageRef page, const void *clientInfo);
 typedef void (*WKPageDidBecomeResponsiveCallback)(WKPageRef page, const void *clientInfo);
+typedef void (*WKPageProcessDidExitCallback)(WKPageRef page, const void *clientInfo);
 
 typedef void (*WKPageDidChangeBackForwardListCallback)(WKPageRef page, const void *clientInfo);
@@ -90 +91 @@
     WKPageDidFinishProgressCallback                                     didFinishProgress;
 
-    // FIXME: These two methods should not be part of this client.
+    // FIXME: These three functions should not be part of this client.
     WKPageDidBecomeUnresponsiveCallback                                 didBecomeUnresponsive;
     WKPageDidBecomeResponsiveCallback                                   didBecomeResponsive;
+    WKPageProcessDidExitCallback                                        processDidExit;
 
     WKPageDidChangeBackForwardListCallback                              didChangeBackForwardList;

trunk/WebKit2/UIProcess/WebLoaderClient.cpp

@@ -128 +128 @@
 }
 
+void WebLoaderClient::processDidExit(WebPageProxy* page)
+{
+    if (m_pageLoaderClient.processDidExit)
+        m_pageLoaderClient.processDidExit(toRef(page), m_pageLoaderClient.clientInfo);
+}
+
 void WebLoaderClient::didChangeBackForwardList(WebPageProxy* page)
 {

trunk/WebKit2/UIProcess/WebLoaderClient.h

@@ -56 +56 @@
     void didFinishProgress(WebPageProxy*);
 
-    // FIXME: These two methods should not be part of this client. 
+    // FIXME: These three functions should not be part of this client.
     void didBecomeUnresponsive(WebPageProxy*);
     void didBecomeResponsive(WebPageProxy*);
+    void processDidExit(WebPageProxy*);
 
     void didChangeBackForwardList(WebPageProxy*);

trunk/WebKit2/UIProcess/WebPageProxy.cpp

@@ -1015 +1015 @@
 
     m_estimatedProgress = 0.0;
-    
+
     m_pageClient->processDidExit();
+    m_loaderClient.processDidExit(this);
 }