Changeset 64140 in webkit

Timestamp:

Jul 27, 2010 10:17:09 AM (14 years ago)

Author:

Adam Roben

Message:

Make preferences APIs robust against web process crashes

Fixes <​http://webkit.org/b/43049> Crash in
WebPageNamespace::preferencesDidChange if preferences are changed
after the web process crashes

Reviewed by Anders Carlsson.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::preferencesDidChange): Bail out if we don't have
a web process. The new preference values will get propogated to the
web process if and when it launches.

Location:

trunk/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebContext.cpp (modified) (1 diff)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-07-27  Adam Roben  <aroben@apple.com>
+
+        Make preferences APIs robust against web process crashes
+
+        Fixes <http://webkit.org/b/43049> Crash in
+        WebPageNamespace::preferencesDidChange if preferences are changed
+        after the web process crashes
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/WebContext.cpp:
+        (WebKit::WebContext::preferencesDidChange): Bail out if we don't have
+        a web process. The new preference values will get propogated to the
+        web process if and when it launches.
+
 2010-07-27  Adam Roben  <aroben@apple.com>
 

trunk/WebKit2/UIProcess/WebContext.cpp

@@ -142 +142 @@
 void WebContext::preferencesDidChange()
 {
+    if (!m_process)
+        return;
+
     for (HashSet<WebPageNamespace*>::iterator it = m_pageNamespaces.begin(), end = m_pageNamespaces.end(); it != end; ++it) {
         WebPageNamespace* pageNamespace = *it;