Changeset 64185 in webkit
- Timestamp:
- Jul 27, 2010 6:50:40 PM (14 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r64175 r64185 1 2010-07-27 Martin Robinson <mrobinson@igalia.com> 2 3 Reviewed by David Levin. 4 5 Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to 6 https://bugs.webkit.org/show_bug.cgi?id=43090 7 8 * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods. 9 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior. 10 1 11 2010-07-27 Kent Tamura <tkent@chromium.org> 2 12 -
trunk/WebKitTools/Scripts/webkitpy/style/checkers/cpp.py
r61666 r64185 1883 1883 # Don't warn about NULL usage in g_str{join,concat}(). See Bug 34834 1884 1884 if search(r'\bg_str(join|concat)\b', line): 1885 return 1886 1887 # Don't warn about NULL usage in gdk_pixbuf_save_to_*{join,concat}(). See Bug 43090. 1888 if search(r'\bgdk_pixbuf_save_to\w+\b', line): 1885 1889 return 1886 1890 -
trunk/WebKitTools/Scripts/webkitpy/style/checkers/cpp_unittest.py
r61666 r64185 3473 3473 'gchar* result = g_strjoin(",", "part1", NULL);', 3474 3474 '') 3475 self.assert_lint( 3476 'gchar* result = gdk_pixbuf_save_to_callback(pixbuf, function, data, type, error, NULL);', 3477 '') 3478 self.assert_lint( 3479 'gchar* result = gdk_pixbuf_save_to_buffer(pixbuf, function, data, type, error, NULL);', 3480 '') 3481 self.assert_lint( 3482 'gchar* result = gdk_pixbuf_save_to_stream(pixbuf, function, data, type, error, NULL);', 3483 '') 3475 3484 3476 3485 # 2. C++ and C bool values should be written as true and
Note: See TracChangeset
for help on using the changeset viewer.