Changeset 64219 in webkit

Timestamp:

Jul 28, 2010 12:23:54 PM (14 years ago)

Author:

tony@chromium.org

Message:

2010-07-28 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] cleanup temp files left by Linux DRT
​https://bugs.webkit.org/show_bug.cgi?id=43062

• BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
• BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left

by crashed DRTs

Location:

trunk/WebKitTools

Files:

• BuildSlaveSupport/build.webkit.org-config/config.json (modified) (2 diffs)
• BuildSlaveSupport/build.webkit.org-config/master.cfg (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json

@@ -36 +36 @@
                     { "name": "szeged-windows-2", "platform": "qt"},
 
-                    { "name": "google-windows-1", "platform": "chromium" },
-                    { "name": "google-mac-1", "platform": "chromium" },
-                    { "name": "google-linux-1", "platform": "chromium" },
-                    { "name": "google-windows-2", "platform": "chromium" },
-                    { "name": "google-mac-2", "platform": "chromium" },
-                    { "name": "google-linux-2", "platform": "chromium" },
+                    { "name": "google-windows-1", "platform": "chromium-win" },
+                    { "name": "google-mac-1", "platform": "chromium-mac" },
+                    { "name": "google-linux-1", "platform": "chromium-linux" },
+                    { "name": "google-windows-2", "platform": "chromium-win" },
+                    { "name": "google-mac-2", "platform": "chromium-mac" },
+                    { "name": "google-linux-2", "platform": "chromium-linux" },
                     { "name": "google-new-tests", "platform": "mac-leopard" }
                   ],
@@ -151 +151 @@
                     {
                       "name": "Chromium Win Release", "type": "Build", "builddir": "chromium-win-release",
-                      "platform": "chromium", "configuration": "release", "architectures": ["i386"],
+                      "platform": "chromium-win", "configuration": "release", "architectures": ["i386"],
                       "slavenames": ["google-windows-1"]
                     },
                     {
                       "name": "Chromium Mac Release", "type": "Build", "builddir": "chromium-mac-release",
-                      "platform": "chromium", "configuration": "release", "architectures": ["i386"],
+                      "platform": "chromium-mac", "configuration": "release", "architectures": ["i386"],
                       "slavenames": ["google-mac-1"]
                     },
                     {
                       "name": "Chromium Linux Release", "type": "Build", "builddir": "chromium-linux-release",
-                      "platform": "chromium", "configuration": "release", "architectures": ["i386"],
+                      "platform": "chromium-linux", "configuration": "release", "architectures": ["i386"],
                       "slavenames": ["google-linux-1"]
                     },
                     {
                       "name": "Chromium Win Release (Tests)", "type": "NewBuildAndTest", "builddir": "chromium-win-release-tests",
-                      "platform": "chromium", "configuration": "release", "architectures": ["i386"],
+                      "platform": "chromium-win", "configuration": "release", "architectures": ["i386"],
                       "slavenames": ["google-windows-2"]
                     },
                     {
                       "name": "Chromium Mac Release (Tests)", "type": "NewBuildAndTest", "builddir": "chromium-mac-release-tests",
-                      "platform": "chromium", "configuration": "release", "architectures": ["i386"],
+                      "platform": "chromium-mac", "configuration": "release", "architectures": ["i386"],
                       "slavenames": ["google-mac-2"]
                     },
                     {
                       "name": "Chromium Linux Release (Tests)", "type": "NewBuildAndTest", "builddir": "chromium-linux-release-tests",
-                      "platform": "chromium", "configuration": "release", "architectures": ["i386"],
+                      "platform": "chromium-linux", "configuration": "release", "architectures": ["i386"],
                       "slavenames": ["google-linux-2"]
                     },

trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg

@@ -69 +69 @@
     haltOnFailure = True
 
+class CleanupChromiumLinuxCrashLogs(shell.ShellCommand):
+    name = "cleanup crash logs"
+    description = ["removing crash logs"]
+    descriptionDone = ["removed crash logs"]
+    command = ["sh", "-c", "rm -rf /tmp/.org.chromium.*"]
+    haltOnFailure = False
+
 
 def appendCustomBuildFlags(step, platform):
@@ -344 +351 @@
             self.addStep(KillOldProcesses)
             self.addStep(InstallWin32Dependencies)
-        if platform == "chromium":
+        if platform.startswith("chromium"):
             self.addStep(InstallChromiumDependencies)
 
@@ -376 +383 @@
     def __init__(self, platform, configuration, architectures):
         Factory.__init__(self, platform, configuration, architectures, False)
+        if platform == "chromium-linux":
+            self.addStep(CleanupChromiumLinuxCrashLogs)
         self.addStep(CompileWebKit)
-        if platform != "chromium":
+        if not platform.startswith("chromium"):
             self.addStep(RunJavaScriptCoreTests)
         self.addStep(self.TestClass)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-07-28  Tony Chang  <tony@chromium.org>
+
+        Reviewed by Kent Tamura.
+
+        [chromium] cleanup temp files left by Linux DRT
+        https://bugs.webkit.org/show_bug.cgi?id=43062
+
+        * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
+        * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
+            by crashed DRTs
+
 2010-07-28  Antonio Gomes  <tonikitoo@webkit.org>