Changeset 64224 in webkit

Timestamp:

Jul 28, 2010 12:54:31 PM (14 years ago)

Author:

Adam Roben

Message:

Teach CoreIPC how to handle with a pipe closing during a write

Fixes <​http://webkit.org/b/43131> Assertion failure in
Connection::sendOutgoingMessage if the other process exits at just the
wrong time

Reviewed by Darin Adler.

• Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::sendOutgoingMessage): If ::WriteFile fails with
ERROR_NO_DATA, the pipe (and thus the connection) has closed.

Location:

trunk/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/CoreIPC/win/ConnectionWin.cpp (modified) (1 diff)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-07-28  Adam Roben  <aroben@apple.com>
+
+        Teach CoreIPC how to handle with a pipe closing during a write
+
+        Fixes <http://webkit.org/b/43131> Assertion failure in
+        Connection::sendOutgoingMessage if the other process exits at just the
+        wrong time
+
+        Reviewed by Darin Adler.
+
+        * Platform/CoreIPC/win/ConnectionWin.cpp:
+        (CoreIPC::Connection::sendOutgoingMessage): If ::WriteFile fails with
+        ERROR_NO_DATA, the pipe (and thus the connection) has closed.
+
 2010-07-28  Adam Roben  <aroben@apple.com>
 

trunk/WebKit2/Platform/CoreIPC/win/ConnectionWin.cpp

@@ -312 +312 @@
 
     DWORD error = ::GetLastError();
+
+    if (error == ERROR_NO_DATA) {
+        // The pipe is being closed.
+        connectionDidClose();
+        return false;
+    }
+
     if (error != ERROR_IO_PENDING) {
         ASSERT_NOT_REACHED();