Changeset 64249 in webkit


Ignore:
Timestamp:
Jul 28, 2010 5:54:20 PM (14 years ago)
Author:
tkent@chromium.org
Message:

2010-07-28 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Introduce drt_expectations.txt for NRWT
https://bugs.webkit.org/show_bug.cgi?id=43123

  • platform/chromium/drt_expectations.txt: Added.

2010-07-28 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Introduce drt_expectations.txt for NRWT
https://bugs.webkit.org/show_bug.cgi?id=43123

Introduce LayoutTests/platform/chromium/drt_expectations.txt,
which overrides test expectations only for DumpRenderTree, in
order to manage what problems are investigated.
This change will be reverted when we switch to DRT completely.

  • Scripts/webkitpy/layout_tests/port/chromium.py: Add drt_expectations.txt content to the result of test_expectations_overrides() if --use-drt is specified.
Location:
trunk
Files:
1 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r64246 r64249  
     12010-07-28  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        [DRT/Chromium] Introduce drt_expectations.txt for NRWT
     6        https://bugs.webkit.org/show_bug.cgi?id=43123
     7
     8        * platform/chromium/drt_expectations.txt: Added.
     9
    1102010-07-28  Anders Carlsson  <andersca@apple.com>
    211
  • trunk/WebKitTools/ChangeLog

    r64247 r64249  
     12010-07-28  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        [DRT/Chromium] Introduce drt_expectations.txt for NRWT
     6        https://bugs.webkit.org/show_bug.cgi?id=43123
     7
     8        Introduce LayoutTests/platform/chromium/drt_expectations.txt,
     9        which overrides test expectations only for DumpRenderTree, in
     10        order to manage what problems are investigated.
     11        This change will be reverted when we switch to DRT completely.
     12
     13        * Scripts/webkitpy/layout_tests/port/chromium.py:
     14         Add drt_expectations.txt content to the result of
     15         test_expectations_overrides() if --use-drt is specified.
     16
    1172010-07-28  Brady Eidson  <beidson@apple.com>
    218
  • trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py

    r64175 r64249  
    214214
    215215    def test_expectations_overrides(self):
     216        # FIXME: This drt_overrides handling should be removed when we switch
     217        # from tes_shell to DRT.
     218        drt_overrides = ''
     219        if self._options.use_drt:
     220            drt_overrides_path = self.path_from_webkit_base('LayoutTests',
     221                'platform', 'chromium', 'drt_expectations.txt')
     222            if os.path.exists(drt_overrides_path):
     223                with codecs.open(drt_overrides_path, "r", "utf-8") as file:
     224                    drt_overrides = file.read()
     225
    216226        try:
    217227            overrides_path = self.path_from_chromium_base('webkit', 'tools',
     
    222232            return None
    223233        with codecs.open(overrides_path, "r", "utf-8") as file:
    224             return file.read()
     234            return file.read() + drt_overrides
    225235
    226236    def test_platform_names(self):
Note: See TracChangeset for help on using the changeset viewer.