Changeset 64260 in webkit

Timestamp:

Jul 28, 2010 8:12:10 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-07-28 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Dimitri Glazkov.

Add a missing dependency.
​https://bugs.webkit.org/show_bug.cgi?id=43044

• css/CSSPrimitiveValueMappings.h:

2010-07-28 Dominic Mazzoni <​dmazzoni@google.com>

Reviewed by Dimitri Glazkov.

Add access to the computed style display to WebAccessibilityObject.
​https://bugs.webkit.org/show_bug.cgi?id=43044

• public/WebAccessibilityObject.h:
• src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::hasComputedStyle): (WebKit::WebAccessibilityObject::computedStyleDisplay):

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/CSSPrimitiveValueMappings.h (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/public/WebAccessibilityObject.h (modified) (1 diff)
• WebKit/chromium/src/WebAccessibilityObject.cpp (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-07-28  Dominic Mazzoni  <dmazzoni@google.com>
+
+        Reviewed by Dimitri Glazkov.
+
+        Add a missing dependency.
+        https://bugs.webkit.org/show_bug.cgi?id=43044
+
+        * css/CSSPrimitiveValueMappings.h:
+
 2010-07-28  Alex Nicolaou  <anicolao@chromium.org>
 

trunk/WebCore/css/CSSPrimitiveValueMappings.h

@@ -37 +37 @@
 #include "GraphicsTypes.h"
 #include "Path.h"
+#include "RenderStyleConstants.h"
 #include "SVGRenderStyleDefs.h"
 #include "TextDirection.h"

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-07-28  Dominic Mazzoni  <dmazzoni@google.com>
+
+        Reviewed by Dimitri Glazkov.
+
+        Add access to the computed style display to WebAccessibilityObject.
+        https://bugs.webkit.org/show_bug.cgi?id=43044
+
+        * public/WebAccessibilityObject.h:
+        * src/WebAccessibilityObject.cpp:
+        (WebKit::WebAccessibilityObject::hasComputedStyle):
+        (WebKit::WebAccessibilityObject::computedStyleDisplay):
+
 2010-07-28  Hans Wennborg  <hans@chromium.org>
 

trunk/WebKit/chromium/public/WebAccessibilityObject.h

@@ -108 +108 @@
     WEBKIT_API WebNode node() const;
     WEBKIT_API WebDocument document() const;
+    WEBKIT_API bool hasComputedStyle() const;
+    WEBKIT_API WebString computedStyleDisplay() const;
 
 #if WEBKIT_IMPLEMENTATION

trunk/WebKit/chromium/src/WebAccessibilityObject.cpp

@@ -33 +33 @@
 
 #include "AccessibilityObject.h"
+#include "CSSPrimitiveValueMappings.h"
 #include "Document.h"
 #include "EventHandler.h"
@@ -38 +39 @@
 #include "Node.h"
 #include "PlatformKeyboardEvent.h"
+#include "RenderStyle.h"
 #include "WebDocument.h"
 #include "WebNode.h"
@@ -435 +437 @@
 }
 
+bool WebAccessibilityObject::hasComputedStyle() const
+{
+    Document* document = m_private->document();
+    if (document)
+        document->updateStyleIfNeeded();
+
+    Node* node = m_private->node();
+    if (!node)
+        return false;
+
+    return node->computedStyle();
+}
+
+WebString WebAccessibilityObject::computedStyleDisplay() const
+{
+    Document* document = m_private->document();
+    if (document)
+        document->updateStyleIfNeeded();
+
+    Node* node = m_private->node();
+    if (!node)
+        return WebString();
+
+    RenderStyle* renderStyle = node->computedStyle();
+    if (!renderStyle)
+        return WebString();
+
+    return WebString(CSSPrimitiveValue::create(renderStyle->display())->getStringValue());
+}
+
 WebAccessibilityObject::WebAccessibilityObject(const WTF::PassRefPtr<WebCore::AccessibilityObject>& object)
     : m_private(static_cast<WebAccessibilityObjectPrivate*>(object.releaseRef()))