Changeset 64317 in webkit
- Timestamp:
- Jul 29, 2010 4:16:36 PM (14 years ago)
- Location:
- trunk/WebKit2
- Files:
-
- 19 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKit2/ChangeLog
r64316 r64317 1 2010-07-29 Brady Eidson <beidson@apple.com> 2 3 Reviewed by Sam Weinig. 4 5 Make all public facing client setters take const pointers 6 https://bugs.webkit.org/show_bug.cgi?id=43219 7 8 * UIProcess/API/C/WKContext.cpp: 9 (WKContextSetInjectedBundleClient): 10 (WKContextSetHistoryClient): 11 * UIProcess/API/C/WKContext.h: 12 13 * UIProcess/API/C/WKPage.cpp: 14 (WKPageSetPageLoaderClient): 15 (WKPageSetPagePolicyClient): 16 (WKPageSetPageUIClient): 17 * UIProcess/API/C/WKPage.h: 18 19 * UIProcess/WebContext.cpp: 20 (WebKit::WebContext::initializeInjectedBundleClient): 21 (WebKit::WebContext::initializeHistoryClient): 22 * UIProcess/WebContext.h: 23 24 * UIProcess/WebContextInjectedBundleClient.cpp: 25 (WebKit::WebContextInjectedBundleClient::initialize): 26 * UIProcess/WebContextInjectedBundleClient.h: 27 28 * UIProcess/WebHistoryClient.cpp: 29 (WebKit::WebHistoryClient::initialize): 30 * UIProcess/WebHistoryClient.h: 31 32 * UIProcess/WebLoaderClient.cpp: 33 (WebKit::WebLoaderClient::initialize): 34 * UIProcess/WebLoaderClient.h: 35 36 * UIProcess/WebPageProxy.cpp: 37 (WebKit::WebPageProxy::initializeLoaderClient): 38 (WebKit::WebPageProxy::initializePolicyClient): 39 (WebKit::WebPageProxy::initializeUIClient): 40 * UIProcess/WebPageProxy.h: 41 42 * UIProcess/WebPolicyClient.cpp: 43 (WebKit::WebPolicyClient::initialize): 44 * UIProcess/WebPolicyClient.h: 45 46 * UIProcess/WebUIClient.cpp: 47 (WebKit::WebUIClient::initialize): 48 * UIProcess/WebUIClient.h: 49 1 50 2010-07-29 Anders Carlsson <andersca@apple.com> 2 51 -
trunk/WebKit2/UIProcess/API/C/WKContext.cpp
r64287 r64317 73 73 } 74 74 75 void WKContextSetInjectedBundleClient(WKContextRef contextRef, WKContextInjectedBundleClient* wkClient)75 void WKContextSetInjectedBundleClient(WKContextRef contextRef, const WKContextInjectedBundleClient* wkClient) 76 76 { 77 77 if (wkClient && !wkClient->version) … … 79 79 } 80 80 81 void WKContextSetHistoryClient(WKContextRef contextRef, WKContextHistoryClient* wkClient)81 void WKContextSetHistoryClient(WKContextRef contextRef, const WKContextHistoryClient* wkClient) 82 82 { 83 83 if (wkClient && !wkClient->version) -
trunk/WebKit2/UIProcess/API/C/WKContext.h
r64253 r64317 70 70 WK_EXPORT WKPreferencesRef WKContextGetPreferences(WKContextRef context); 71 71 72 WK_EXPORT void WKContextSetHistoryClient(WKContextRef context, WKContextHistoryClient* client);73 WK_EXPORT void WKContextSetInjectedBundleClient(WKContextRef context, WKContextInjectedBundleClient* client);72 WK_EXPORT void WKContextSetHistoryClient(WKContextRef context, const WKContextHistoryClient* client); 73 WK_EXPORT void WKContextSetInjectedBundleClient(WKContextRef context, const WKContextInjectedBundleClient* client); 74 74 75 75 WK_EXPORT void WKContextPostMessageToInjectedBundle(WKContextRef context, WKStringRef message); -
trunk/WebKit2/UIProcess/API/C/WKPage.cpp
r64253 r64317 132 132 } 133 133 134 void WKPageSetPageLoaderClient(WKPageRef pageRef, WKPageLoaderClient* wkClient)134 void WKPageSetPageLoaderClient(WKPageRef pageRef, const WKPageLoaderClient* wkClient) 135 135 { 136 136 if (wkClient && !wkClient->version) … … 138 138 } 139 139 140 void WKPageSetPagePolicyClient(WKPageRef pageRef, WKPagePolicyClient* wkClient)140 void WKPageSetPagePolicyClient(WKPageRef pageRef, const WKPagePolicyClient* wkClient) 141 141 { 142 142 if (wkClient && !wkClient->version) … … 144 144 } 145 145 146 void WKPageSetPageUIClient(WKPageRef pageRef, WKPageUIClient * wkClient)146 void WKPageSetPageUIClient(WKPageRef pageRef, const WKPageUIClient * wkClient) 147 147 { 148 148 if (wkClient && !wkClient->version) -
trunk/WebKit2/UIProcess/API/C/WKPage.h
r64253 r64317 161 161 WK_EXPORT void WKPageTerminate(WKPageRef page); 162 162 163 WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, WKPageLoaderClient* client);164 WK_EXPORT void WKPageSetPagePolicyClient(WKPageRef page, WKPagePolicyClient* client);165 WK_EXPORT void WKPageSetPageUIClient(WKPageRef page, WKPageUIClient* client);163 WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClient* client); 164 WK_EXPORT void WKPageSetPagePolicyClient(WKPageRef page, const WKPagePolicyClient* client); 165 WK_EXPORT void WKPageSetPageUIClient(WKPageRef page, const WKPageUIClient* client); 166 166 167 167 typedef void (*WKPageRunJavaScriptFunction)(WKStringRef, void*); -
trunk/WebKit2/UIProcess/WebContext.cpp
r64287 r64317 84 84 } 85 85 86 void WebContext::initializeInjectedBundleClient( WKContextInjectedBundleClient* client)86 void WebContext::initializeInjectedBundleClient(const WKContextInjectedBundleClient* client) 87 87 { 88 88 m_injectedBundleClient.initialize(client); 89 89 } 90 90 91 void WebContext::initializeHistoryClient( WKContextHistoryClient* client)91 void WebContext::initializeHistoryClient(const WKContextHistoryClient* client) 92 92 { 93 93 m_historyClient.initialize(client); -
trunk/WebKit2/UIProcess/WebContext.h
r64287 r64317 59 59 ~WebContext(); 60 60 61 void initializeInjectedBundleClient( WKContextInjectedBundleClient*);62 void initializeHistoryClient( WKContextHistoryClient*);61 void initializeInjectedBundleClient(const WKContextInjectedBundleClient*); 62 void initializeHistoryClient(const WKContextHistoryClient*); 63 63 64 64 ProcessModel processModel() const { return m_processModel; } -
trunk/WebKit2/UIProcess/WebContextInjectedBundleClient.cpp
r64029 r64317 38 38 } 39 39 40 void WebContextInjectedBundleClient::initialize( WKContextInjectedBundleClient* client)40 void WebContextInjectedBundleClient::initialize(const WKContextInjectedBundleClient* client) 41 41 { 42 42 if (client && !client->version) -
trunk/WebKit2/UIProcess/WebContextInjectedBundleClient.h
r64029 r64317 40 40 public: 41 41 WebContextInjectedBundleClient(); 42 void initialize( WKContextInjectedBundleClient*);42 void initialize(const WKContextInjectedBundleClient*); 43 43 44 44 void didReceiveMessageFromInjectedBundle(WebContext*, const WebCore::String&); -
trunk/WebKit2/UIProcess/WebHistoryClient.cpp
r64247 r64317 39 39 } 40 40 41 void WebHistoryClient::initialize( WKContextHistoryClient* client)41 void WebHistoryClient::initialize(const WKContextHistoryClient* client) 42 42 { 43 43 if (client && !client->version) -
trunk/WebKit2/UIProcess/WebHistoryClient.h
r64247 r64317 43 43 public: 44 44 WebHistoryClient(); 45 void initialize( WKContextHistoryClient*);45 void initialize(const WKContextHistoryClient*); 46 46 47 47 void didNavigateWithNavigationData(WebContext*, WebPageProxy*, const WebNavigationDataStore&, WebFrameProxy*); -
trunk/WebKit2/UIProcess/WebLoaderClient.cpp
r64132 r64317 36 36 } 37 37 38 void WebLoaderClient::initialize( WKPageLoaderClient* client)38 void WebLoaderClient::initialize(const WKPageLoaderClient* client) 39 39 { 40 40 if (client && !client->version) -
trunk/WebKit2/UIProcess/WebLoaderClient.h
r64132 r64317 41 41 public: 42 42 WebLoaderClient(); 43 void initialize( WKPageLoaderClient*);43 void initialize(const WKPageLoaderClient*); 44 44 45 45 void didStartProvisionalLoadForFrame(WebPageProxy*, WebFrameProxy*); -
trunk/WebKit2/UIProcess/WebPageProxy.cpp
r64247 r64317 108 108 } 109 109 110 void WebPageProxy::initializeLoaderClient( WKPageLoaderClient* loadClient)110 void WebPageProxy::initializeLoaderClient(const WKPageLoaderClient* loadClient) 111 111 { 112 112 m_loaderClient.initialize(loadClient); 113 113 } 114 114 115 void WebPageProxy::initializePolicyClient( WKPagePolicyClient* policyClient)115 void WebPageProxy::initializePolicyClient(const WKPagePolicyClient* policyClient) 116 116 { 117 117 m_policyClient.initialize(policyClient); 118 118 } 119 119 120 void WebPageProxy::initializeUIClient( WKPageUIClient* client)120 void WebPageProxy::initializeUIClient(const WKPageUIClient* client) 121 121 { 122 122 m_uiClient.initialize(client); -
trunk/WebKit2/UIProcess/WebPageProxy.h
r64253 r64317 90 90 91 91 void setPageClient(PageClient*); 92 void initializeLoaderClient( WKPageLoaderClient*);93 void initializePolicyClient( WKPagePolicyClient*);94 void initializeUIClient( WKPageUIClient*);92 void initializeLoaderClient(const WKPageLoaderClient*); 93 void initializePolicyClient(const WKPagePolicyClient*); 94 void initializeUIClient(const WKPageUIClient*); 95 95 96 96 void revive(); -
trunk/WebKit2/UIProcess/WebPolicyClient.cpp
r63455 r64317 38 38 } 39 39 40 void WebPolicyClient::initialize( WKPagePolicyClient* client)40 void WebPolicyClient::initialize(const WKPagePolicyClient* client) 41 41 { 42 42 if (client && !client->version) -
trunk/WebKit2/UIProcess/WebPolicyClient.h
r63455 r64317 43 43 public: 44 44 WebPolicyClient(); 45 void initialize( WKPagePolicyClient*);45 void initialize(const WKPagePolicyClient*); 46 46 47 47 bool decidePolicyForNavigationAction(WebPageProxy*, WebCore::NavigationType, const WebCore::String& url, WebFrameProxy*, WebFramePolicyListenerProxy*); -
trunk/WebKit2/UIProcess/WebUIClient.cpp
r64232 r64317 39 39 } 40 40 41 void WebUIClient::initialize( WKPageUIClient* client)41 void WebUIClient::initialize(const WKPageUIClient* client) 42 42 { 43 43 if (client && !client->version) -
trunk/WebKit2/UIProcess/WebUIClient.h
r64065 r64317 41 41 public: 42 42 WebUIClient(); 43 void initialize( WKPageUIClient*);43 void initialize(const WKPageUIClient*); 44 44 45 45 WebPageProxy* createNewPage(WebPageProxy*);
Note: See TracChangeset
for help on using the changeset viewer.