Changeset 64317 in webkit


Ignore:
Timestamp:
Jul 29, 2010 4:16:36 PM (14 years ago)
Author:
beidson@apple.com
Message:

2010-07-29 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Make all public facing client setters take const pointers
https://bugs.webkit.org/show_bug.cgi?id=43219

  • UIProcess/API/C/WKContext.cpp: (WKContextSetInjectedBundleClient): (WKContextSetHistoryClient):
  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKPage.cpp: (WKPageSetPageLoaderClient): (WKPageSetPagePolicyClient): (WKPageSetPageUIClient):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::initializeInjectedBundleClient): (WebKit::WebContext::initializeHistoryClient):
  • UIProcess/WebContext.h:
  • UIProcess/WebContextInjectedBundleClient.cpp: (WebKit::WebContextInjectedBundleClient::initialize):
  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebHistoryClient.cpp: (WebKit::WebHistoryClient::initialize):
  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::initialize):
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeLoaderClient): (WebKit::WebPageProxy::initializePolicyClient): (WebKit::WebPageProxy::initializeUIClient):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPolicyClient.cpp: (WebKit::WebPolicyClient::initialize):
  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::initialize):
  • UIProcess/WebUIClient.h:
Location:
trunk/WebKit2
Files:
19 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit2/ChangeLog

    r64316 r64317  
     12010-07-29  Brady Eidson  <beidson@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        Make all public facing client setters take const pointers
     6        https://bugs.webkit.org/show_bug.cgi?id=43219
     7
     8        * UIProcess/API/C/WKContext.cpp:
     9        (WKContextSetInjectedBundleClient):
     10        (WKContextSetHistoryClient):
     11        * UIProcess/API/C/WKContext.h:
     12
     13        * UIProcess/API/C/WKPage.cpp:
     14        (WKPageSetPageLoaderClient):
     15        (WKPageSetPagePolicyClient):
     16        (WKPageSetPageUIClient):
     17        * UIProcess/API/C/WKPage.h:
     18
     19        * UIProcess/WebContext.cpp:
     20        (WebKit::WebContext::initializeInjectedBundleClient):
     21        (WebKit::WebContext::initializeHistoryClient):
     22        * UIProcess/WebContext.h:
     23
     24        * UIProcess/WebContextInjectedBundleClient.cpp:
     25        (WebKit::WebContextInjectedBundleClient::initialize):
     26        * UIProcess/WebContextInjectedBundleClient.h:
     27
     28        * UIProcess/WebHistoryClient.cpp:
     29        (WebKit::WebHistoryClient::initialize):
     30        * UIProcess/WebHistoryClient.h:
     31
     32        * UIProcess/WebLoaderClient.cpp:
     33        (WebKit::WebLoaderClient::initialize):
     34        * UIProcess/WebLoaderClient.h:
     35
     36        * UIProcess/WebPageProxy.cpp:
     37        (WebKit::WebPageProxy::initializeLoaderClient):
     38        (WebKit::WebPageProxy::initializePolicyClient):
     39        (WebKit::WebPageProxy::initializeUIClient):
     40        * UIProcess/WebPageProxy.h:
     41
     42        * UIProcess/WebPolicyClient.cpp:
     43        (WebKit::WebPolicyClient::initialize):
     44        * UIProcess/WebPolicyClient.h:
     45
     46        * UIProcess/WebUIClient.cpp:
     47        (WebKit::WebUIClient::initialize):
     48        * UIProcess/WebUIClient.h:
     49
    1502010-07-29  Anders Carlsson  <andersca@apple.com>
    251
  • trunk/WebKit2/UIProcess/API/C/WKContext.cpp

    r64287 r64317  
    7373}
    7474
    75 void WKContextSetInjectedBundleClient(WKContextRef contextRef, WKContextInjectedBundleClient* wkClient)
     75void WKContextSetInjectedBundleClient(WKContextRef contextRef, const WKContextInjectedBundleClient* wkClient)
    7676{
    7777    if (wkClient && !wkClient->version)
     
    7979}
    8080
    81 void WKContextSetHistoryClient(WKContextRef contextRef, WKContextHistoryClient * wkClient)
     81void WKContextSetHistoryClient(WKContextRef contextRef, const WKContextHistoryClient* wkClient)
    8282{
    8383    if (wkClient && !wkClient->version)
  • trunk/WebKit2/UIProcess/API/C/WKContext.h

    r64253 r64317  
    7070WK_EXPORT WKPreferencesRef WKContextGetPreferences(WKContextRef context);
    7171
    72 WK_EXPORT void WKContextSetHistoryClient(WKContextRef context, WKContextHistoryClient * client);
    73 WK_EXPORT void WKContextSetInjectedBundleClient(WKContextRef context, WKContextInjectedBundleClient * client);
     72WK_EXPORT void WKContextSetHistoryClient(WKContextRef context, const WKContextHistoryClient* client);
     73WK_EXPORT void WKContextSetInjectedBundleClient(WKContextRef context, const WKContextInjectedBundleClient* client);
    7474
    7575WK_EXPORT void WKContextPostMessageToInjectedBundle(WKContextRef context, WKStringRef message);
  • trunk/WebKit2/UIProcess/API/C/WKPage.cpp

    r64253 r64317  
    132132}
    133133
    134 void WKPageSetPageLoaderClient(WKPageRef pageRef, WKPageLoaderClient* wkClient)
     134void WKPageSetPageLoaderClient(WKPageRef pageRef, const WKPageLoaderClient* wkClient)
    135135{
    136136    if (wkClient && !wkClient->version)
     
    138138}
    139139
    140 void WKPageSetPagePolicyClient(WKPageRef pageRef, WKPagePolicyClient * wkClient)
     140void WKPageSetPagePolicyClient(WKPageRef pageRef, const WKPagePolicyClient* wkClient)
    141141{
    142142    if (wkClient && !wkClient->version)
     
    144144}
    145145
    146 void WKPageSetPageUIClient(WKPageRef pageRef, WKPageUIClient * wkClient)
     146void WKPageSetPageUIClient(WKPageRef pageRef, const WKPageUIClient * wkClient)
    147147{
    148148    if (wkClient && !wkClient->version)
  • trunk/WebKit2/UIProcess/API/C/WKPage.h

    r64253 r64317  
    161161WK_EXPORT void WKPageTerminate(WKPageRef page);
    162162
    163 WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, WKPageLoaderClient * client);
    164 WK_EXPORT void WKPageSetPagePolicyClient(WKPageRef page, WKPagePolicyClient * client);
    165 WK_EXPORT void WKPageSetPageUIClient(WKPageRef page, WKPageUIClient * client);
     163WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClient* client);
     164WK_EXPORT void WKPageSetPagePolicyClient(WKPageRef page, const WKPagePolicyClient* client);
     165WK_EXPORT void WKPageSetPageUIClient(WKPageRef page, const WKPageUIClient* client);
    166166
    167167typedef void (*WKPageRunJavaScriptFunction)(WKStringRef, void*);
  • trunk/WebKit2/UIProcess/WebContext.cpp

    r64287 r64317  
    8484}
    8585
    86 void WebContext::initializeInjectedBundleClient(WKContextInjectedBundleClient* client)
     86void WebContext::initializeInjectedBundleClient(const WKContextInjectedBundleClient* client)
    8787{
    8888    m_injectedBundleClient.initialize(client);
    8989}
    9090
    91 void WebContext::initializeHistoryClient(WKContextHistoryClient* client)
     91void WebContext::initializeHistoryClient(const WKContextHistoryClient* client)
    9292{
    9393    m_historyClient.initialize(client);
  • trunk/WebKit2/UIProcess/WebContext.h

    r64287 r64317  
    5959    ~WebContext();
    6060
    61     void initializeInjectedBundleClient(WKContextInjectedBundleClient*);
    62     void initializeHistoryClient(WKContextHistoryClient*);
     61    void initializeInjectedBundleClient(const WKContextInjectedBundleClient*);
     62    void initializeHistoryClient(const WKContextHistoryClient*);
    6363
    6464    ProcessModel processModel() const { return m_processModel; }
  • trunk/WebKit2/UIProcess/WebContextInjectedBundleClient.cpp

    r64029 r64317  
    3838}
    3939
    40 void WebContextInjectedBundleClient::initialize(WKContextInjectedBundleClient* client)
     40void WebContextInjectedBundleClient::initialize(const WKContextInjectedBundleClient* client)
    4141{
    4242    if (client && !client->version)
  • trunk/WebKit2/UIProcess/WebContextInjectedBundleClient.h

    r64029 r64317  
    4040public:
    4141    WebContextInjectedBundleClient();
    42     void initialize(WKContextInjectedBundleClient*);
     42    void initialize(const WKContextInjectedBundleClient*);
    4343
    4444    void didReceiveMessageFromInjectedBundle(WebContext*, const WebCore::String&);
  • trunk/WebKit2/UIProcess/WebHistoryClient.cpp

    r64247 r64317  
    3939}
    4040
    41 void WebHistoryClient::initialize(WKContextHistoryClient* client)
     41void WebHistoryClient::initialize(const WKContextHistoryClient* client)
    4242{
    4343    if (client && !client->version)
  • trunk/WebKit2/UIProcess/WebHistoryClient.h

    r64247 r64317  
    4343public:
    4444    WebHistoryClient();
    45     void initialize(WKContextHistoryClient*);
     45    void initialize(const WKContextHistoryClient*);
    4646
    4747    void didNavigateWithNavigationData(WebContext*, WebPageProxy*, const WebNavigationDataStore&, WebFrameProxy*);
  • trunk/WebKit2/UIProcess/WebLoaderClient.cpp

    r64132 r64317  
    3636}
    3737
    38 void WebLoaderClient::initialize(WKPageLoaderClient* client)
     38void WebLoaderClient::initialize(const WKPageLoaderClient* client)
    3939{
    4040    if (client && !client->version)
  • trunk/WebKit2/UIProcess/WebLoaderClient.h

    r64132 r64317  
    4141public:
    4242    WebLoaderClient();
    43     void initialize(WKPageLoaderClient*);
     43    void initialize(const WKPageLoaderClient*);
    4444
    4545    void didStartProvisionalLoadForFrame(WebPageProxy*, WebFrameProxy*);
  • trunk/WebKit2/UIProcess/WebPageProxy.cpp

    r64247 r64317  
    108108}
    109109
    110 void WebPageProxy::initializeLoaderClient(WKPageLoaderClient* loadClient)
     110void WebPageProxy::initializeLoaderClient(const WKPageLoaderClient* loadClient)
    111111{
    112112    m_loaderClient.initialize(loadClient);
    113113}
    114114
    115 void WebPageProxy::initializePolicyClient(WKPagePolicyClient* policyClient)
     115void WebPageProxy::initializePolicyClient(const WKPagePolicyClient* policyClient)
    116116{
    117117    m_policyClient.initialize(policyClient);
    118118}
    119119
    120 void WebPageProxy::initializeUIClient(WKPageUIClient* client)
     120void WebPageProxy::initializeUIClient(const WKPageUIClient* client)
    121121{
    122122    m_uiClient.initialize(client);
  • trunk/WebKit2/UIProcess/WebPageProxy.h

    r64253 r64317  
    9090
    9191    void setPageClient(PageClient*);
    92     void initializeLoaderClient(WKPageLoaderClient*);
    93     void initializePolicyClient(WKPagePolicyClient*);
    94     void initializeUIClient(WKPageUIClient*);
     92    void initializeLoaderClient(const WKPageLoaderClient*);
     93    void initializePolicyClient(const WKPagePolicyClient*);
     94    void initializeUIClient(const WKPageUIClient*);
    9595
    9696    void revive();
  • trunk/WebKit2/UIProcess/WebPolicyClient.cpp

    r63455 r64317  
    3838}
    3939
    40 void WebPolicyClient::initialize(WKPagePolicyClient* client)
     40void WebPolicyClient::initialize(const WKPagePolicyClient* client)
    4141{
    4242    if (client && !client->version)
  • trunk/WebKit2/UIProcess/WebPolicyClient.h

    r63455 r64317  
    4343public:
    4444    WebPolicyClient();
    45     void initialize(WKPagePolicyClient*);
     45    void initialize(const WKPagePolicyClient*);
    4646
    4747    bool decidePolicyForNavigationAction(WebPageProxy*, WebCore::NavigationType, const WebCore::String& url, WebFrameProxy*, WebFramePolicyListenerProxy*);
  • trunk/WebKit2/UIProcess/WebUIClient.cpp

    r64232 r64317  
    3939}
    4040
    41 void WebUIClient::initialize(WKPageUIClient* client)
     41void WebUIClient::initialize(const WKPageUIClient* client)
    4242{
    4343    if (client && !client->version)
  • trunk/WebKit2/UIProcess/WebUIClient.h

    r64065 r64317  
    4141public:
    4242    WebUIClient();
    43     void initialize(WKPageUIClient*);
     43    void initialize(const WKPageUIClient*);
    4444
    4545    WebPageProxy* createNewPage(WebPageProxy*);
Note: See TracChangeset for help on using the changeset viewer.