Changeset 64347 in webkit


Ignore:
Timestamp:
Jul 30, 2010 4:10:14 AM (14 years ago)
Author:
Nikolas Zimmermann
Message:

2010-07-30 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

svg/dynamic-updates: cursor attribute changes not respected
​https://bugs.webkit.org/show_bug.cgi?id=42615

Turns out the tests were wrong, specifying a hot spot which is too large.
Switched to a larger cursor image to make the changes easier to detect, when using the browser.

All svg/dynamic-updates tests work again, without regressions.

  • platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png:
  • svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt:
  • svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt:
  • svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.txt:
  • svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.txt:
  • svg/dynamic-updates/script-tests/SVGCursorElement-dom-x-attr.js:
  • svg/dynamic-updates/script-tests/SVGCursorElement-dom-y-attr.js:
  • svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-x-prop.js:
  • svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-y-prop.js:
Location:
trunk/LayoutTests
Files:
17 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r64343 r64347  
     12010-07-30  Nikolas Zimmermann  <nzimmermann@rim.com>
     2
     3        Reviewed by Dirk Schulze.
     4
     5        svg/dynamic-updates: cursor attribute changes not respected
     6        https://bugs.webkit.org/show_bug.cgi?id=42615
     7
     8        Turns out the tests were wrong, specifying a hot spot which is too large.
     9        Switched to a larger cursor image to make the changes easier to detect, when using the browser.
     10
     11        All svg/dynamic-updates tests work again, without regressions.
     12
     13        * platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum:
     14        * platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
     15        * platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum:
     16        * platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
     17        * platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum:
     18        * platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png:
     19        * platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum:
     20        * platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png:
     21        * svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt:
     22        * svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt:
     23        * svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.txt:
     24        * svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.txt:
     25        * svg/dynamic-updates/script-tests/SVGCursorElement-dom-x-attr.js:
     26        * svg/dynamic-updates/script-tests/SVGCursorElement-dom-y-attr.js:
     27        * svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-x-prop.js:
     28        * svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-y-prop.js:
     29
    1302010-07-30  Kent Tamura  <tkent@chromium.org>
    231

  • trunk/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum

    r63730 r64347  
    1 68e6ddad4147b871f21014d9f34cc4e5
     16155be7c28c9029d052f4244c484c4b0

  • trunk/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum

    r63730 r64347  
    1 fc80a9f8c6d315d743e21bced6cf8f04
     11ca091212f0ea37247c5ac67d7f53c25

  • trunk/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum

    r63730 r64347  
    1 5d7a14c0f87bf6bf73471689f10964f3
     1866fd8429aa1147a1a2de901cf2713b1

  • trunk/LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum

    r63730 r64347  
    1 385120b220874b27c01178693b3de163
     1961b13541f3270374f5024a7f548e323

  • trunk/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.txt

    r35683 r64347  
    66
    77
    8 PASS cursorElement.getAttribute('x') is "500"
     8PASS cursorElement.getAttribute('x') is "100"
    99PASS cursorElement.getAttribute('x') is "0"
    1010PASS successfullyParsed is true

  • trunk/LayoutTests/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.txt

    r35683 r64347  
    66
    77
    8 PASS cursorElement.getAttribute('y') is "500"
     8PASS cursorElement.getAttribute('y') is "100"
    99PASS cursorElement.getAttribute('y') is "0"
    1010PASS successfullyParsed is true

  • trunk/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.txt

    r35683 r64347  
    66
    77
    8 PASS cursorElement.x.baseVal.value is 500
     8PASS cursorElement.x.baseVal.value is 100
    99PASS cursorElement.x.baseVal.value is 0
    1010PASS successfullyParsed is true

  • trunk/LayoutTests/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.txt

    r35683 r64347  
    66
    77
    8 PASS cursorElement.y.baseVal.value is 500
     8PASS cursorElement.y.baseVal.value is 100
    99PASS cursorElement.y.baseVal.value is 0
    1010PASS successfullyParsed is true

  • trunk/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-dom-x-attr.js

    r48554 r64347  
    11// [Name] SVGCursorElement-dom-x-attr.js
    2 // [Expected rendering result] verify manually that the cursor is visible when hovering the rect - and a series of PASS messages
     2// [Expected rendering result] cursor image should hang from the upper-left corner of the cursor after clicking - and a series of PASS mesasges
    33
    44description("Tests dynamic updates of the 'x' attribute of the SVGCursorElement object")
    … …  
    77var cursorElement = createSVGElement("cursor");
    88cursorElement.setAttribute("id", "cursor");
    9 cursorElement.setAttribute("x", "500");
    10 cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/magnify.png");
     9cursorElement.setAttribute("x", "100");
     10cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/sphere.png");
    1111rootSVGElement.appendChild(cursorElement);
    1212
    … …  
    1818rootSVGElement.appendChild(rectElement);
    1919
    20 shouldBeEqualToString("cursorElement.getAttribute('x')", "500");
     20shouldBeEqualToString("cursorElement.getAttribute('x')", "100");
    2121
    2222function executeTest() {

  • trunk/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-dom-y-attr.js

    r48554 r64347  
    11// [Name] SVGCursorElement-dom-y-attr.js
    2 // [Expected rendering result] verify manually that the cursor is visible when hovering the rect - and a series of PASS messages
     2// [Expected rendering result] cursor image should hang from the upper-left corner of the cursor after clicking - and a series of PASS mesasges
    33
    44description("Tests dynamic updates of the 'y' attribute of the SVGCursorElement object")
    … …  
    77var cursorElement = createSVGElement("cursor");
    88cursorElement.setAttribute("id", "cursor");
    9 cursorElement.setAttribute("y", "500");
    10 cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/magnify.png");
     9cursorElement.setAttribute("y", "100");
     10cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/sphere.png");
    1111rootSVGElement.appendChild(cursorElement);
    1212
    … …  
    1818rootSVGElement.appendChild(rectElement);
    1919
    20 shouldBeEqualToString("cursorElement.getAttribute('y')", "500");
     20shouldBeEqualToString("cursorElement.getAttribute('y')", "100");
    2121
    2222function executeTest() {

  • trunk/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-x-prop.js

    r48554 r64347  
    11// [Name] SVGCursorElement-svgdom-x-prop.js
    2 // [Expected rendering result] verify manually that the cursor is visible when hovering the rect - and a series of PASS messages
     2// [Expected rendering result] cursor image should hang from the upper-left corner of the cursor after clicking - and a series of PASS mesasges
    33
    44description("Tests dynamic updates of the 'x' property of the SVGCursorElement object")
    … …  
    77var cursorElement = createSVGElement("cursor");
    88cursorElement.setAttribute("id", "cursor");
    9 cursorElement.setAttribute("x", "500");
    10 cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/magnify.png");
     9cursorElement.setAttribute("x", "100");
     10cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/sphere.png");
    1111rootSVGElement.appendChild(cursorElement);
    1212
    … …  
    1818rootSVGElement.appendChild(rectElement);
    1919
    20 shouldBe("cursorElement.x.baseVal.value", "500");
     20shouldBe("cursorElement.x.baseVal.value", "100");
    2121
    2222function executeTest() {

  • trunk/LayoutTests/svg/dynamic-updates/script-tests/SVGCursorElement-svgdom-y-prop.js

    r48554 r64347  
    1 // [Name] SVGCursorElement-sgdom-y-prop.js
    2 // [Expected rendering result] verify manually that the cursor is visible when hovering the rect - and a series of PASS messages
     1// [Name] SVGCursorElement-svgdom-y-prop.js
     2// [Expected rendering result] cursor image should hang from the upper-left corner of the cursor after clicking - and a series of PASS mesasges
    33
    44description("Tests dynamic updates of the 'y' property of the SVGCursorElement object")
    … …  
    77var cursorElement = createSVGElement("cursor");
    88cursorElement.setAttribute("id", "cursor");
    9 cursorElement.setAttribute("y", "500");
    10 cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/magnify.png");
     9cursorElement.setAttribute("y", "100");
     10cursorElement.setAttributeNS(xlinkNS, "xlink:href", "../W3C-SVG-1.1/resources/sphere.png");
    1111rootSVGElement.appendChild(cursorElement);
    1212
    … …  
    1818rootSVGElement.appendChild(rectElement);
    1919
    20 shouldBe("cursorElement.y.baseVal.value", "500");
     20shouldBe("cursorElement.y.baseVal.value", "100");
    2121
    2222function executeTest() {
Note: See TracChangeset for help on using the changeset viewer.