Changeset 64352 in webkit

Timestamp:

Jul 30, 2010 6:19:26 AM (14 years ago)

Author:

jorlow@chromium.org

Message:

2010-07-30 Satish Sampath <​satish@chromium.org>

Reviewed by Jeremy Orlow.

Add a check for WebViewClient being null.
​https://bugs.webkit.org/show_bug.cgi?id=43240

• src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::SpeechInputClientImpl):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/SpeechInputClientImpl.cpp (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-07-30  Satish Sampath  <satish@chromium.org>
+
+        Reviewed by Jeremy Orlow.
+
+        Add a check for WebViewClient being null.
+        https://bugs.webkit.org/show_bug.cgi?id=43240
+
+        * src/SpeechInputClientImpl.cpp:
+        (WebKit::SpeechInputClientImpl::SpeechInputClientImpl):
+
 2010-07-30  Hans Wennborg  <hans@chromium.org>
 

trunk/WebKit/chromium/src/SpeechInputClientImpl.cpp

@@ -43 +43 @@
 
 SpeechInputClientImpl::SpeechInputClientImpl(WebViewClient* web_view_client)
-    : m_controller(web_view_client->speechInputController(this))
+    : m_controller(web_view_client ? web_view_client->speechInputController(this) : 0)
     , m_listener(0)
 {
-    // FIXME: Right now WebViewClient gives a null pointer, and with the
-    // runtime flag for speech input feature set to true by default this will
-    // always assert. Enable this assert once the WebViewClient starts to
-    // give a valid pointer.
-    // ASSERT(m_controller);
 }