Changeset 64491 in webkit

Timestamp:

Aug 2, 2010 2:03:38 PM (14 years ago)

Author:

jhoneycutt@apple.com

Message:

Add a Skipped list on Windows, and have run-webkit-tests respect it.

Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
there are zero tests failing
​https://bugs.webkit.org/show_bug.cgi?id=43374

Reviewed by Adam Roben.

WebKitTools:

• Scripts/old-run-webkit-tests:

If using WebKitTestRunner and Apple Windows WebKit, set the platform to
win-wk2. When building the result hierarchy, if the platform is win-wk2,
add it first to the list of platforms.

LayoutTests:

• platform/win-wk2/Skipped: Copied from LayoutTests/platform/mac-wk2/Skipped.

All platform/mac tests removed.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/win-wk2 (added)
• LayoutTests/platform/win-wk2/Skipped (added)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/Scripts/old-run-webkit-tests (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
+
+        Add a Skipped list on Windows, and have run-webkit-tests respect it.
+
+        Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
+        there are zero tests failing
+        https://bugs.webkit.org/show_bug.cgi?id=43374
+
+        Reviewed by Adam Roben.
+
+        * platform/win-wk2/Skipped: Copied from LayoutTests/platform/mac-wk2/Skipped.
+        All platform/mac tests removed.
+
 2010-07-20  Ojan Vafai  <ojan@chromium.org>
 

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
+
+        Add a Skipped list on Windows, and have run-webkit-tests respect it.
+
+        Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
+        there are zero tests failing
+        https://bugs.webkit.org/show_bug.cgi?id=43374
+
+        Reviewed by Adam Roben.
+
+        * Scripts/old-run-webkit-tests:
+        If using WebKitTestRunner and Apple Windows WebKit, set the platform to
+        win-wk2. When building the result hierarchy, if the platform is win-wk2,
+        add it first to the list of platforms.
+
 2010-08-02  Darin Adler  <darin@apple.com>
 

trunk/WebKitTools/Scripts/old-run-webkit-tests

@@ -355 +355 @@
         $realPlatform = $platform;
         $platform = "mac-wk2";
+    } elsif (isAppleWinWebKit()) {
+        $realPlatform = $platform;
+        $platform = "win-wk2";
     }
 }
@@ -1896 +1899 @@
     if ($isMac || $isWin) {
         my $effectivePlatform = $platform;
-        if ($platform eq "mac-wk2") {
-            push @platforms, "mac-wk2";
+        if ($platform eq "mac-wk2" || $platform eq "win-wk2") {
+            push @platforms, $platform;
             $effectivePlatform = $realPlatform;
         }