Changeset 64492 in webkit

Timestamp:

Aug 2, 2010 2:10:52 PM (14 years ago)

Author:

beidson@apple.com

Message:

2010-08-02 Brady Eidson <​beidson@apple.com>

Reviewed by Anders Carlsson.

Basic WK2 visited link coloring
​https://bugs.webkit.org/show_bug.cgi?id=43377

No new tests. (No change in behavior)

• WebCore.exp.in:

• page/PageGroup.cpp: (WebCore::PageGroup::addVisitedLinkHash):
• page/PageGroup.h:

2010-08-02 Brady Eidson <​beidson@apple.com>

Reviewed by Anders Carlsson.

Basic WK2 visited link coloring
​https://bugs.webkit.org/show_bug.cgi?id=43377

Add simple API that allows the WK2 app to add 1 visited link at a time.
For now, this just pipes each individual LinkHash down to WebCore.

• Shared/CoreIPCSupport/WebProcessMessageKinds.h: (WebProcessMessage::):

• UIProcess/API/C/WKContext.cpp: (WKContextAddVisitedLink):
• UIProcess/API/C/WKContext.h:

• UIProcess/WebContext.cpp: (WebKit::WebContext::addVisitedLink):
• UIProcess/WebContext.h:

• WebProcess/WebProcess.cpp: (WebKit::WebProcess::addVisitedLinkHash): (WebKit::WebProcess::didReceiveMessage):
• WebProcess/WebProcess.h:

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/WebCore.exp.in (modified) (2 diffs)
• WebCore/page/PageGroup.cpp (modified) (1 diff)
• WebCore/page/PageGroup.h (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/Shared/CoreIPCSupport/WebProcessMessageKinds.h (modified) (1 diff)
• WebKit2/UIProcess/API/C/WKContext.cpp (modified) (1 diff)
• WebKit2/UIProcess/API/C/WKContext.h (modified) (1 diff)
• WebKit2/UIProcess/WebContext.cpp (modified) (2 diffs)
• WebKit2/UIProcess/WebContext.h (modified) (1 diff)
• WebKit2/WebProcess/WebProcess.cpp (modified) (2 diffs)
• WebKit2/WebProcess/WebProcess.h (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-08-02  Brady Eidson  <beidson@apple.com>
+
+        Reviewed by Anders Carlsson.
+
+        Basic WK2 visited link coloring
+        https://bugs.webkit.org/show_bug.cgi?id=43377
+
+        No new tests. (No change in behavior)
+
+        * WebCore.exp.in:
+        
+        * page/PageGroup.cpp:
+        (WebCore::PageGroup::addVisitedLinkHash):
+        * page/PageGroup.h:
+
 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
 

trunk/WebCore/WebCore.exp.in

@@ -362 +362 @@
 __ZN7WebCore15VisiblePositionC1ERKNS_8PositionENS_9EAffinityE
 __ZN7WebCore15reportExceptionEPN3JSC9ExecStateENS0_7JSValueE
+__ZN7WebCore15visitedLinkHashEPKtj
 __ZN7WebCore16AbstractDatabase14setIsAvailableEb
 __ZN7WebCore16FontFallbackList15releaseFontDataEv
@@ -815 +816 @@
 __ZN7WebCore9PageGroup14addVisitedLinkEPKtm
 __ZN7WebCore9PageGroup17closeLocalStorageEv
+__ZN7WebCore9PageGroup18addVisitedLinkHashEy
 __ZN7WebCore9PageGroup20addUserScriptToWorldEPNS_15DOMWrapperWorldERKNS_6StringERKNS_4KURLEN3WTF10PassOwnPtrINS9_6VectorIS3_Lm0EEEEESD_NS_23UserScriptInjectionTimeENS_25UserContentInjectedFramesE
 __ZN7WebCore9PageGroup20removeAllUserContentEv

trunk/WebCore/page/PageGroup.cpp

@@ -137 +137 @@
 }
 
+void PageGroup::addVisitedLinkHash(LinkHash hash)
+{
+    addVisitedLink(hash);
+}
+
 inline void PageGroup::addVisitedLink(LinkHash hash)
 {

trunk/WebCore/page/PageGroup.h

@@ -59 +59 @@
         void addVisitedLink(const KURL&);
         void addVisitedLink(const UChar*, size_t);
+        void addVisitedLinkHash(LinkHash);
         void removeVisitedLinks();
 

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-08-02  Brady Eidson  <beidson@apple.com>
+
+        Reviewed by Anders Carlsson.
+
+        Basic WK2 visited link coloring
+        https://bugs.webkit.org/show_bug.cgi?id=43377
+
+        Add simple API that allows the WK2 app to add 1 visited link at a time.
+        For now, this just pipes each individual LinkHash down to WebCore.
+        
+        * Shared/CoreIPCSupport/WebProcessMessageKinds.h:
+        (WebProcessMessage::):
+
+        * UIProcess/API/C/WKContext.cpp:
+        (WKContextAddVisitedLink):
+        * UIProcess/API/C/WKContext.h:
+
+        * UIProcess/WebContext.cpp:
+        (WebKit::WebContext::addVisitedLink):
+        * UIProcess/WebContext.h:
+
+        * WebProcess/WebProcess.cpp:
+        (WebKit::WebProcess::addVisitedLinkHash):
+        (WebKit::WebProcess::didReceiveMessage):
+        * WebProcess/WebProcess.h:
+
 2010-08-02  Darin Adler  <darin@apple.com>
 

trunk/WebKit2/Shared/CoreIPCSupport/WebProcessMessageKinds.h

@@ -34 +34 @@
 
 enum Kind {
+    AddVisitedLink,
     LoadInjectedBundle,
     SetApplicationCacheDirectory,

trunk/WebKit2/UIProcess/API/C/WKContext.cpp

@@ -95 +95 @@
 }
 
+void WKContextAddVisitedLink(WKContextRef contextRef, WKStringRef visitedURL)
+{
+    toWK(contextRef)->addVisitedLink(toWK(visitedURL)->string());
+}
+
 WKContextRef WKContextRetain(WKContextRef contextRef)
 {

trunk/WebKit2/UIProcess/API/C/WKContext.h

@@ -75 +75 @@
 WK_EXPORT void WKContextPostMessageToInjectedBundle(WKContextRef context, WKStringRef messageName, WKTypeRef messageBody);
 
+WK_EXPORT void WKContextAddVisitedLink(WKContextRef context, WKStringRef visitedURL);
+
 WK_EXPORT WKContextRef WKContextRetain(WKContextRef context);
 WK_EXPORT void WKContextRelease(WKContextRef context);

trunk/WebKit2/UIProcess/WebContext.cpp

@@ -40 +40 @@
 #include "WKContextPrivate.h"
 
+#include <WebCore/LinkHash.h>
+
 #ifndef NDEBUG
 #include <wtf/RefCountedLeakCounter.h>
@@ -365 +367 @@
 }
 
+void WebContext::addVisitedLink(const String& visitedURL)
+{
+    if (visitedURL.isEmpty())
+        return;
+
+    WebCore::LinkHash hash = visitedLinkHash(visitedURL.characters(), visitedURL.length());
+    m_process->send(WebProcessMessage::AddVisitedLink, 0, CoreIPC::In(hash));
+}
+
 void WebContext::didReceiveMessage(CoreIPC::Connection* connection, CoreIPC::MessageID messageID, CoreIPC::ArgumentDecoder& arguments)
 {

trunk/WebKit2/UIProcess/WebContext.h

@@ -100 +100 @@
     
     void registerURLSchemeAsEmptyDocument(const WebCore::String&);
+    
+    void addVisitedLink(const WebCore::String&);
 
     void didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder&);

trunk/WebKit2/WebProcess/WebProcess.cpp

@@ -111 +111 @@
 }
 
+void WebProcess::addVisitedLinkHash(WebCore::LinkHash hash)
+{
+    PageGroup* group = PageGroup::pageGroup("WebKit2Group");
+    ASSERT(group);
+    if (!group) {
+        printf("Cannot find PageGroup named 'WebKit2Group'\n");
+        return;
+    }
+    group->addVisitedLinkHash(hash);
+}
+
 WebPage* WebProcess::webPage(uint64_t pageID) const
 {
@@ -167 +178 @@
     if (messageID.is<CoreIPC::MessageClassWebProcess>()) {
         switch (messageID.get<WebProcessMessage::Kind>()) {
+            case WebProcessMessage::AddVisitedLink: {
+                WebCore::LinkHash hash;
+                if (!arguments->decode(CoreIPC::Out(hash)))
+                    return;
+
+                addVisitedLinkHash(hash);
+                return;
+            }
             case WebProcessMessage::LoadInjectedBundle: {
                 String path;

trunk/WebKit2/WebProcess/WebProcess.h

@@ -29 +29 @@
 #include "Connection.h"
 #include "DrawingArea.h"
+#include <WebCore/LinkHash.h>
 #include <wtf/HashMap.h>
 
@@ -74 +75 @@
     void setApplicationCacheDirectory(const WebCore::String&);
     void registerURLSchemeAsEmptyDocument(const WebCore::String&);
+    void addVisitedLinkHash(WebCore::LinkHash);
 
     // CoreIPC::Connection::Client