Changeset 64542 in webkit

Timestamp:

Aug 3, 2010 3:12:34 AM (14 years ago)

Author:

tkent@chromium.org

Message:

2010-08-03 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Initiate speech input requests on click event
​https://bugs.webkit.org/show_bug.cgi?id=43352

• rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/TextControlInnerElements.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-08-03  Satish Sampath  <satish@chromium.org>
+
+        Reviewed by Kent Tamura.
+
+        Initiate speech input requests on click event
+        https://bugs.webkit.org/show_bug.cgi?id=43352
+
+        * rendering/TextControlInnerElements.cpp:
+        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
+
 2010-08-02  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/WebCore/rendering/TextControlInnerElements.cpp

@@ -373 +373 @@
         event->setDefaultHandled();
     }
-    // On mouse up, start speech recognition.
+    // On mouse up, release capture cleanly.
     if (event->type() == eventNames().mouseupEvent && event->isMouseEvent() && static_cast<MouseEvent*>(event)->button() == LeftButton) {
         if (m_capturing && renderer() && renderer()->visibleToHitTesting()) {
@@ -380 +380 @@
                 m_capturing = false;
             }
-            if (hovered()) {
-                speechInput()->startRecognition(this);
-                event->setDefaultHandled();
-            }
-        }
+        }
+    }
+
+    if (event->type() == eventNames().clickEvent) {
+        speechInput()->startRecognition(this);
+        event->setDefaultHandled();
     }