Changeset 64564 in webkit

Timestamp:

Aug 3, 2010 10:39:50 AM (14 years ago)

Author:

andersca@apple.com

Message:

Frequent ASSERT_NOT_REACHED in Connection::processIncomingMessage when running regression tests
​https://bugs.webkit.org/show_bug.cgi?id=42926
<rdar://problem/8237329>

Reviewed by Adam Roben.

Remove this assert, it's bogus. It would fire when a reply came in on the connection queue before
waitForReply was called on the client thread, but that case is already covered.

• Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):

Location:

trunk/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/CoreIPC/Connection.cpp (modified) (1 diff)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-08-03  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Adam Roben.
+
+        Frequent ASSERT_NOT_REACHED in Connection::processIncomingMessage when running regression tests
+        https://bugs.webkit.org/show_bug.cgi?id=42926
+        <rdar://problem/8237329>
+
+        Remove this assert, it's bogus. It would fire when a reply came in on the connection queue before 
+        waitForReply was called on the client thread, but that case is already covered.
+
+        * Platform/CoreIPC/Connection.cpp:
+        (CoreIPC::Connection::processIncomingMessage):
+
 2010-08-03  Adam Roben  <aroben@apple.com>
 

trunk/WebKit2/Platform/CoreIPC/Connection.cpp

@@ -176 +176 @@
     }
 
-    if (messageID == MessageID(CoreIPCMessage::SyncMessageReply)) {
-        // FIXME: We got a reply for another sync message someone sent, handle this.
-        ASSERT_NOT_REACHED();
-    }
-
     MutexLocker locker(m_incomingMessagesLock);
     m_incomingMessages.append(IncomingMessage(messageID, arguments));