Changeset 64567 in webkit

Timestamp:

Aug 3, 2010 11:08:25 AM (14 years ago)

Author:

kov@webkit.org

Message:

2010-08-03 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Does not paint the node highlight used by the inspector
​https://bugs.webkit.org/show_bug.cgi?id=43429

Implement highlighting the nodes when using the inspector.

• WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::highlight): (WebKit::InspectorClient::hideHighlight):
• webkit/webkitwebview.cpp: (webkit_web_view_expose_event):

Location:

trunk/WebKit/gtk

Files:

• ChangeLog (modified) (2 diffs)
• WebCoreSupport/InspectorClientGtk.cpp (modified) (1 diff)
• webkit/webkitwebview.cpp (modified) (1 diff)

trunk/WebKit/gtk/ChangeLog

@@ +1 @@
+2010-08-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
+
+        Reviewed by Xan Lopez.
+
+        [GTK] Does not paint the node highlight used by the inspector
+        https://bugs.webkit.org/show_bug.cgi?id=43429
+
+        Implement highlighting the nodes when using the inspector.
+
+        * WebCoreSupport/InspectorClientGtk.cpp:
+        (WebKit::InspectorClient::highlight):
+        (WebKit::InspectorClient::hideHighlight):
+        * webkit/webkitwebview.cpp:
+        (webkit_web_view_expose_event):
+
 2010-08-03  Xan Lopez  <xlopez@igalia.com>
 
@@ -149 +164 @@
         (WebKit::ChromeClient::reachedApplicationCacheOriginQuota):
         * WebCoreSupport/ChromeClientGtk.h:
-
 2010-07-26  Steve Block  <steveblock@google.com>
 

trunk/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp

@@ -102 +102 @@
 }
 
-void InspectorClient::highlight(Node* node)
-{
-    notImplemented();
+void InspectorClient::highlight(Node*)
+{
+    hideHighlight();
 }
 
 void InspectorClient::hideHighlight()
 {
-    notImplemented();
+    // FIXME: we should be able to only invalidate the actual rects of
+    // the new and old nodes. We need to track the nodes, and take the
+    // actual highlight size into account when calculating the damage
+    // rect.
+    gtk_widget_queue_draw(GTK_WIDGET(m_inspectedWebView));
 }
 

trunk/WebKit/gtk/webkit/webkitwebview.cpp

@@ -550 +550 @@
             }
         }
+
+        ctx.save();
+        ctx.clip(static_cast<IntRect>(event->area));
+        frame->page()->inspectorController()->drawNodeHighlight(ctx);
+        ctx.restore();
     }