Changeset 64616 in webkit


Ignore:
Timestamp:
Aug 3, 2010 7:07:38 PM (14 years ago)
Author:
tkent@chromium.org
Message:

<input type=number> UI: Support wheel events
https://bugs.webkit.org/show_bug.cgi?id=42441

Reviewed by Ojan Vafai.

WebCore:

Test: fast/forms/input-number-wheel.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler):

Call stepUpFromRenderer() for wheelDeltaY.

LayoutTests:

  • fast/forms/input-number-wheel-expected.txt: Added.
  • fast/forms/input-number-wheel.html: Added.
  • fast/forms/script-tests/input-number-wheel.js: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r64613 r64616  
     12010-08-03  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Ojan Vafai.
     4
     5        <input type=number> UI: Support wheel events
     6        https://bugs.webkit.org/show_bug.cgi?id=42441
     7
     8        * fast/forms/input-number-wheel-expected.txt: Added.
     9        * fast/forms/input-number-wheel.html: Added.
     10        * fast/forms/script-tests/input-number-wheel.js: Added.
     11
    1122010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
    213
  • trunk/WebCore/ChangeLog

    r64613 r64616  
     12010-08-03  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Ojan Vafai.
     4
     5        <input type=number> UI: Support wheel events
     6        https://bugs.webkit.org/show_bug.cgi?id=42441
     7
     8        Test: fast/forms/input-number-wheel.html
     9
     10        * html/HTMLInputElement.cpp:
     11        (WebCore::HTMLInputElement::defaultEventHandler):
     12         Call stepUpFromRenderer() for wheelDeltaY.
     13
    1142010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
    215
  • trunk/WebCore/html/HTMLInputElement.cpp

    r64152 r64616  
    6868#include "StringHash.h"
    6969#include "TextEvent.h"
     70#include "WheelEvent.h"
    7071#include <wtf/HashMap.h>
    7172#include <wtf/MathExtras.h>
     
    24082409        handleBeforeTextInsertedEvent(evt);
    24092410
     2411    if (hasSpinButton() && evt->isWheelEvent()) {
     2412        WheelEvent* wheel = static_cast<WheelEvent*>(evt);
     2413        int step = 0;
     2414        if (wheel->wheelDeltaY() > 0) {
     2415            step = 1;
     2416        } else if (wheel->wheelDeltaY() < 0) {
     2417            step = -1;
     2418        }
     2419        if (step) {
     2420            stepUpFromRenderer(step);
     2421            evt->setDefaultHandled();
     2422            return;
     2423        }
     2424    }
    24102425    if (isTextField() && renderer() && (evt->isMouseEvent() || evt->isDragEvent() || evt->isWheelEvent() || evt->type() == eventNames().blurEvent || evt->type() == eventNames().focusEvent))
    24112426        toRenderTextControlSingleLine(renderer())->forwardEvent(evt);
Note: See TracChangeset for help on using the changeset viewer.