Changeset 64654 in webkit

Timestamp:

Aug 4, 2010 10:12:43 AM (14 years ago)

Author:

aa@chromium.org

Message:

2010-08-04 Aaron Boodman <​aa@chromium.org>

Reviewed by Eric Seidel.

prepare-ChangeLog fails mysteriously if curl doesn't support ssl
​https://bugs.webkit.org/show_bug.cgi?id=43460

• Scripts/prepare-ChangeLog:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/prepare-ChangeLog (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-08-04  Aaron Boodman  <aa@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        prepare-ChangeLog fails mysteriously if curl doesn't support ssl
+        https://bugs.webkit.org/show_bug.cgi?id=43460
+
+        * Scripts/prepare-ChangeLog:
+
 2010-08-03  MORITA Hajime  <morrita@google.com>
 

trunk/WebKitTools/Scripts/prepare-ChangeLog

@@ -265 +265 @@
     my $descriptionLine = `curl --insecure --silent "$bugXMLURL" | grep short_desc`;
     if ($descriptionLine !~ /<short_desc>(.*)<\/short_desc>/) {
-        print STDERR "  Bug $bugNumber has no bug description. Maybe you set wrong bug ID?\n";
-        print STDERR "  The bug URL: $bugXMLURL\n";
+        # Maybe the reason the above did not work is because the curl that is installed doesn't
+        # support ssl at all.
+        if (`curl --version | grep ^Protocols` !~ /\bhttps\b/) {
+            print STDERR "  Could not get description for bug $bugNumber.\n";
+            print STDERR "  It looks like your version of curl does not support ssl.\n";
+            print STDERR "  If you are using macports, this can be fixed with sudo port install curl+ssl.\n";
+        } else {
+            print STDERR "  Bug $bugNumber has no bug description. Maybe you set wrong bug ID?\n";
+            print STDERR "  The bug URL: $bugXMLURL\n";
+        }
         exit 1;
     }