Changeset 64711 in webkit

Timestamp:

Aug 4, 2010 10:51:33 PM (14 years ago)

Author:

tkent@chromium.org

Message:

Spin-button behavior improvement for out-of-range values
​https://bugs.webkit.org/show_bug.cgi?id=43463

Reviewed by Darin Adler.

WebCore:

If the current value is smaller than the minimum value, the up
button should change the value to the minimum value. If the
current value is larger than the maximum value, the down button
should change the value to the maximum value.

Test: fast/forms/input-number-outofrange.html

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::stepUpFromRenderer):

LayoutTests:

• fast/forms/input-number-outofrange-expected.txt: Added.
• fast/forms/input-number-outofrange.html: Added.
• fast/forms/script-tests/input-number-outofrange.js: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/input-number-outofrange-expected.txt (added)
• LayoutTests/fast/forms/input-number-outofrange.html (added)
• LayoutTests/fast/forms/script-tests/input-number-outofrange.js (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLInputElement.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-08-04  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Spin-button behavior improvement for out-of-range values
+        https://bugs.webkit.org/show_bug.cgi?id=43463
+
+        * fast/forms/input-number-outofrange-expected.txt: Added.
+        * fast/forms/input-number-outofrange.html: Added.
+        * fast/forms/script-tests/input-number-outofrange.js: Added.
+
 2010-08-04  Kent Tamura  <tkent@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-08-04  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Spin-button behavior improvement for out-of-range values
+        https://bugs.webkit.org/show_bug.cgi?id=43463
+
+        If the current value is smaller than the minimum value, the up
+        button should change the value to the minimum value. If the
+        current value is larger than the maximum value, the down button
+        should change the value to the maximum value.
+
+        Test: fast/forms/input-number-outofrange.html
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::stepUpFromRenderer):
+
 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
 

trunk/WebCore/html/HTMLInputElement.cpp

@@ -2818 +2818 @@
 void HTMLInputElement::stepUpFromRenderer(int n)
 {
-    // The difference from stepUp()/stepDown() is:
-    // If the current value is invalid, the value will be
-    //  - the minimum value if n > 0
-    //  - the maximum value if n < 0
+    // The differences from stepUp()/stepDown():
+    // If the current value is not a number, the value will be
+    //  - The value should be the minimum value if n > 0
+    //  - The value should be the maximum value if n < 0
+    // If the current value is smaller than the minimum value:
+    //  - The value should be the minimum value if n > 0
+    //  - Nothing should happen if n < 0
+    // If the current value is larger than the maximum value:
+    //  - The value should be the maximum value if n < 0
+    //  - Nothing should happen if n > 0
 
     ASSERT(hasSpinButton());
@@ -2833 +2839 @@
     String currentStringValue = value();
     double current = parseToDouble(currentStringValue, nan);
-    if (!isfinite(current))
+    if (!isfinite(current) || (n > 0 && current < minimum()) || (n < 0 && current > maximum()))
         setValue(serialize(n > 0 ? minimum() : maximum()));
     else {