Changeset 64805 in webkit


Ignore:
Timestamp:
Aug 5, 2010 5:46:10 PM (14 years ago)
Author:
arv@chromium.org
Message:

2010-08-05 Erik Arvidsson <arv@chromium.org>

Reviewed by Kent Tamura.

Calling setCustomValidity should trigger a layout
https://bugs.webkit.org/show_bug.cgi?id=43582

  • fast/forms/setCustomValidity-expected.txt: Added.
  • fast/forms/setCustomValidity.html: Added.

2010-08-05 Erik Arvidsson <arv@chromium.org>

Reviewed by Kent Tamura.

Calling setCustomValidity should trigger a layout
https://bugs.webkit.org/show_bug.cgi?id=43582

Test: fast/forms/setCustomValidity.html

  • html/ValidityState.cpp: (WebCore::ValidityState::setCustomErrorMessage): Call setNeedsValidityCheck to tell the system that the validity might have changed.
  • html/ValidityState.h:
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r64799 r64805  
     12010-08-05  Erik Arvidsson  <arv@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Calling setCustomValidity should trigger a layout
     6        https://bugs.webkit.org/show_bug.cgi?id=43582
     7
     8        * fast/forms/setCustomValidity-expected.txt: Added.
     9        * fast/forms/setCustomValidity.html: Added.
     10
    1112010-08-05  Adam Barth  <abarth@webkit.org>
    212
  • trunk/WebCore/ChangeLog

    r64803 r64805  
     12010-08-05  Erik Arvidsson  <arv@chromium.org>
     2
     3        Reviewed by Kent Tamura.
     4
     5        Calling setCustomValidity should trigger a layout
     6        https://bugs.webkit.org/show_bug.cgi?id=43582
     7
     8        Test: fast/forms/setCustomValidity.html
     9
     10        * html/ValidityState.cpp:
     11        (WebCore::ValidityState::setCustomErrorMessage): Call setNeedsValidityCheck to tell the system that the validity might have changed.
     12        * html/ValidityState.h:
     13
    1142010-08-05  Sam Weinig  <sam@webkit.org>
    215
  • trunk/WebCore/html/ValidityState.cpp

    r61677 r64805  
    6565
    6666    return String();
     67}
     68
     69void ValidityState::setCustomErrorMessage(const String& message)
     70{
     71    m_customErrorMessage = message;
     72    m_control->setNeedsValidityCheck();
    6773}
    6874
  • trunk/WebCore/html/ValidityState.h

    r53364 r64805  
    4242    String validationMessage() const;
    4343
    44     void setCustomErrorMessage(const String& message) { m_customErrorMessage = message; }
     44    void setCustomErrorMessage(const String&);
    4545
    4646    bool valueMissing() const { return m_control->valueMissing(); }
Note: See TracChangeset for help on using the changeset viewer.