Changeset 64819 in webkit

Timestamp:

Aug 5, 2010 10:57:08 PM (14 years ago)

Author:

benm@google.com

Message:

2010-08-05 Ben Murdoch <​benm@google.com>

Reviewed by Simon Fraser.

Form button input elements lacking text in some cases after switching from visibility:collapse to visibility:visible
​https://bugs.webkit.org/show_bug.cgi?id=38050

• fast/css/visibility-collapse-form-buttons-expected.txt: Added.
• fast/css/visibility-collapse-form-buttons.html: Added.

2010-08-05 Ben Murdoch <​benm@google.com>

Reviewed by Simon Fraser.

Form button input elements lacking text in some cases after switching from
visibility:collapse to visibility:visible
​https://bugs.webkit.org/show_bug.cgi?id=38050

A relayout is required after toggling visibility from collapse to another value.

Test: fast/css/visibility-collapse-form-buttons.html

• rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): If we're toggling from visibility:collapse to another

visibility value (or vice versa) then we need to trigger a relayout.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/visibility-collapse-form-buttons-expected.txt (added)
• LayoutTests/fast/css/visibility-collapse-form-buttons.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/style/RenderStyle.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-08-05  Ben Murdoch  <benm@google.com>
+
+        Reviewed by Simon Fraser.
+
+        Form button input elements lacking text in some cases after switching from visibility:collapse to visibility:visible
+        https://bugs.webkit.org/show_bug.cgi?id=38050
+
+        * fast/css/visibility-collapse-form-buttons-expected.txt: Added.
+        * fast/css/visibility-collapse-form-buttons.html: Added.
+
 2010-08-05  Alexey Proskuryakov  <ap@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-08-05  Ben Murdoch  <benm@google.com>
+
+        Reviewed by Simon Fraser.
+
+        Form button input elements lacking text in some cases after switching from
+        visibility:collapse to visibility:visible
+        https://bugs.webkit.org/show_bug.cgi?id=38050
+        
+        A relayout is required after toggling visibility from collapse to another value.
+
+        Test: fast/css/visibility-collapse-form-buttons.html
+
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::RenderStyle::diff): If we're toggling from visibility:collapse to another
+            visibility value (or vice versa) then we need to trigger a relayout.
+
 2010-08-05  Alexey Proskuryakov  <ap@apple.com>
 

trunk/WebCore/rendering/style/RenderStyle.cpp

@@ -472 +472 @@
         return StyleDifferenceLayout;
     }
+
+    if ((visibility() == COLLAPSE) != (other->visibility() == COLLAPSE))
+        return StyleDifferenceLayout;
 
     // Make sure these left/top/right/bottom checks stay below all layout checks and above