Changeset 64890 in webkit

Timestamp:

Aug 6, 2010 6:56:07 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-08-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (r64712): YouTube video pages have contents of <noembed> elements overlapping the video description
​https://bugs.webkit.org/show_bug.cgi?id=43605

Show test progression. We missed this regression when analyzing the
expectation diffs because the DOM was correct and was a progression.

• fast/dom/no-elements-expected.txt:
• platform/mac/fast/parser/nofoo-tags-inside-paragraph-expected.txt:

2010-08-06 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION (r64712): YouTube video pages have contents of <noembed> elements overlapping the video description
​https://bugs.webkit.org/show_bug.cgi?id=43605

The old parser used to drop <noembed> on the floor. We're supposed to
add it to the DOM, but we don't want to create a renderer for it.

• html/HTMLElement.cpp: (WebCore::HTMLElement::rendererIsNeeded):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/no-elements-expected.txt (modified) (1 diff)
• LayoutTests/platform/mac/fast/parser/nofoo-tags-inside-paragraph-expected.txt (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLElement.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-08-06  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        REGRESSION (r64712): YouTube video pages have contents of <noembed> elements overlapping the video description
+        https://bugs.webkit.org/show_bug.cgi?id=43605
+
+        Show test progression.  We missed this regression when analyzing the
+        expectation diffs because the DOM was correct and was a progression.
+
+        * fast/dom/no-elements-expected.txt:
+        * platform/mac/fast/parser/nofoo-tags-inside-paragraph-expected.txt:
+
 2010-08-06  Dimitri Glazkov  <dglazkov@chromium.org>
 

trunk/LayoutTests/fast/dom/no-elements-expected.txt

@@ -1 +1 @@
 This tests that the elements noframes, nolayer, noscript and noembed are created as elements and put in the DOM tree. The elements other than <nolayer> should not contain any children. If the test is successful, the four messages below will list 0, 0, 0, and 1 child.
 
-This is noembed. This is nolayer.
+This is nolayer.
 noframes has 1 children.
 noscript has 1 children.

trunk/LayoutTests/platform/mac/fast/parser/nofoo-tags-inside-paragraph-expected.txt

@@ -31 +31 @@
         RenderText {#text} at (0,0) size 329x18
           text run at (0,0) width 329: "This sentence contains noembed tags and should be "
-        RenderInline {NOEMBED} at (0,0) size 0x0
         RenderText {#text} at (329,0) size 74x18
           text run at (329,0) width 74: "on one line."

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-08-06  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        REGRESSION (r64712): YouTube video pages have contents of <noembed> elements overlapping the video description
+        https://bugs.webkit.org/show_bug.cgi?id=43605
+
+        The old parser used to drop <noembed> on the floor.  We're supposed to
+        add it to the DOM, but we don't want to create a renderer for it.
+
+        * html/HTMLElement.cpp:
+        (WebCore::HTMLElement::rendererIsNeeded):
+
 2010-08-06  Tony Gentilcore  <tonyg@chromium.org>
 

trunk/WebCore/html/HTMLElement.cpp

@@ -987 +987 @@
     return inEitherTagList(newChild);
 }
-    
+
 bool HTMLElement::rendererIsNeeded(RenderStyle *style)
 {
@@ -995 +995 @@
         if (frame && frame->script()->canExecuteScripts(NotAboutToExecuteScript))
             return false;
-    }
+    } else
 #endif
+    if (hasLocalName(noembedTag)) {
+        Frame* frame = document()->frame();
+        if (frame && frame->loader()->subframeLoader()->allowPlugins(NotAboutToInstantiatePlugin))
+            return false;
+    }
     return StyledElement::rendererIsNeeded(style);
 }
-    
+
 RenderObject* HTMLElement::createRenderer(RenderArena* arena, RenderStyle* style)
 {