Changeset 64901 in webkit

Timestamp:

Aug 7, 2010 2:25:48 AM (14 years ago)

Author:

Nikolas Zimmermann

Message:

2010-08-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Daniel Bates.

Pattern fill with image not rendered after reload
​https://bugs.webkit.org/show_bug.cgi?id=41596

Fixed by a one-liner. Instead of just invalidating it's own resources, images also have to update
resources in the ancestor chain, if imageChanged() has been called (for example, a slow loading image)

Test: http/tests/misc/slow-loading-image-in-pattern.html

• rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged):

2010-08-07 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Daniel Bates.

Pattern fill with image not rendered after reload
​https://bugs.webkit.org/show_bug.cgi?id=41596

Added test verifying that resources are properly updated, if an image child element has changed.

• http/tests/misc/slow-loading-image-in-pattern.html: Added.
• platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
• platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
• platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/misc/slow-loading-image-in-pattern.html (added)
• LayoutTests/platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum (added)
• LayoutTests/platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png (added)
• LayoutTests/platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderSVGImage.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-08-07  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        Reviewed by Daniel Bates.
+
+        Pattern fill with image not rendered after reload
+        https://bugs.webkit.org/show_bug.cgi?id=41596
+
+        Added test verifying that resources are properly updated, if an image child element has changed.
+
+        * http/tests/misc/slow-loading-image-in-pattern.html: Added.
+        * platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
+        * platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
+        * platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
+
 2010-08-07  Kent Tamura  <tkent@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-08-07  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        Reviewed by Daniel Bates.
+
+        Pattern fill with image not rendered after reload
+        https://bugs.webkit.org/show_bug.cgi?id=41596
+
+        Fixed by a one-liner. Instead of just invalidating it's own resources, images also have to update
+        resources in the ancestor chain, if imageChanged() has been called (for example, a slow loading image)
+
+        Test: http/tests/misc/slow-loading-image-in-pattern.html
+
+        * rendering/RenderSVGImage.cpp:
+        (WebCore::RenderSVGImage::imageChanged):
+
 2010-08-06  Dirk Schulze  <krit@webkit.org>
 

trunk/WebCore/rendering/RenderSVGImage.cpp

@@ -180 +180 @@
         resources->invalidateClient(this);
 
+    // Eventually notify parent resources, that we've changed.
+    RenderSVGResource::markForLayoutAndParentResourceInvalidation(this, false);
+
     repaint();
 }