Changeset 64929 in webkit


Ignore:
Timestamp:
Aug 7, 2010 7:22:57 PM (14 years ago)
Author:
weinig@apple.com
Message:

WebKitTestRunner needs layoutTestController.dumpTitleChanges
<rdar://problem/8213861>
​https://bugs.webkit.org/show_bug.cgi?id=42683

Reviewed by Maciej Stachowiak.

WebKitTools:

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::dumpTitleChanges):
(WTR::LayoutTestController::shouldDumpTitleChanges):

LayoutTests:

  • platform/mac-wk2/Skipped:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r64928 r64929  
     12010-08-07  Sam Weinig  <sam@webkit.org>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        WebKitTestRunner needs layoutTestController.dumpTitleChanges
     6        <rdar://problem/8213861>
     7        https://bugs.webkit.org/show_bug.cgi?id=42683
     8
     9        * platform/mac-wk2/Skipped:
     10
    1112010-08-07  Sam Weinig  <sam@webkit.org>
    212

  • trunk/LayoutTests/platform/mac-wk2/Skipped

    r64928 r64929  
    16971697fast/js/navigator-language.html
    16981698
    1699 # WebKitTestRunner needs layoutTestController.dumpTitleChanges
    1700 # <https://bugs.webkit.org/show_bug.cgi?id=42683>
    1701 fast/dom/title-text-property-2.html
    1702 fast/dom/title-text-property.html
    1703 
    17041699# WebKitTestRunner needs layoutTestController.setCacheModel
    17051700# <https://bugs.webkit.org/show_bug.cgi?id=42684>

  • trunk/WebKitTools/ChangeLog

    r64928 r64929  
     12010-08-07  Sam Weinig  <sam@webkit.org>
     2
     3        Reviewed by Maciej Stachowiak.
     4
     5        WebKitTestRunner needs layoutTestController.dumpTitleChanges
     6        <rdar://problem/8213861>
     7        https://bugs.webkit.org/show_bug.cgi?id=42683
     8
     9        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
     10        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
     11        (WTR::InjectedBundlePage::didReceiveTitleForFrame):
     12        (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
     13        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
     14        (WTR::LayoutTestController::LayoutTestController):
     15        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
     16        (WTR::LayoutTestController::dumpTitleChanges):
     17        (WTR::LayoutTestController::shouldDumpTitleChanges):
     18
    1192010-08-07  Sam Weinig  <sam@webkit.org>
    220

  • trunk/WebKitTools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl

    r64485 r64929  
    3838        void dumpSelectionRect();
    3939        void dumpStatusCallbacks();
     40        void dumpTitleChanges();
    4041
    4142        // Special options.

  • trunk/WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp

    r64928 r64929  
    384384void InjectedBundlePage::didReceiveTitleForFrame(WKStringRef title, WKBundleFrameRef frame)
    385385{
     386    if (!InjectedBundle::shared().layoutTestController()->shouldDumpTitleChanges())
     387        return;
     388
     389    InjectedBundle::shared().os() << "TITLE CHANGED: " << title << "\n";
    386390}
    387391
    … …  
    407411void InjectedBundlePage::didFinishDocumentLoadForFrame(WKBundleFrameRef frame)
    408412{
    409    
    410413    unsigned pendingFrameUnloadEvents = WKBundleFrameGetPendingUnloadCount(frame);
    411414    if (pendingFrameUnloadEvents)

  • trunk/WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp

    r64921 r64929  
    8989    , m_dumpEditingCallbacks(false)
    9090    , m_dumpStatusCallbacks(false)
     91    , m_dumpTitleChanges(false)
    9192    , m_waitToDump(false)
    9293    , m_testRepaint(false)

  • trunk/WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.h

    r64921 r64929  
    5656    void dumpSelectionRect() { } // Will need to do something when we support pixel tests.
    5757    void dumpStatusCallbacks() { m_dumpStatusCallbacks = true; }
     58    void dumpTitleChanges() { m_dumpTitleChanges = true; }
    5859
    5960    // Special options.
    … …  
    8889
    8990    bool shouldDumpStatusCallbacks() const { return m_dumpStatusCallbacks; }
     91    bool shouldDumpTitleChanges() const { return m_dumpTitleChanges; }
    9092
    9193    bool waitToDump() const { return m_waitToDump; }
    … …  
    108110    bool m_dumpEditingCallbacks;
    109111    bool m_dumpStatusCallbacks;
     112    bool m_dumpTitleChanges;
    110113    bool m_waitToDump; // True if waitUntilDone() has been called, but notifyDone() has not yet been called.
    111114    bool m_testRepaint;
Note: See TracChangeset for help on using the changeset viewer.