Changeset 64946 in webkit

Timestamp:

Aug 8, 2010 12:55:52 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-08-08 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

frame()->selection() can't be null
​https://bugs.webkit.org/show_bug.cgi?id=43681

SelectionController is a component of Frame. If frame is non-null, it
can't possibly be null.

• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setActive):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLAnchorElement.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-08-08  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        frame()->selection() can't be null
+        https://bugs.webkit.org/show_bug.cgi?id=43681
+
+        SelectionController is a component of Frame.  If frame is non-null, it
+        can't possibly be null.
+
+        * html/HTMLAnchorElement.cpp:
+        (WebCore::HTMLAnchorElement::setActive):
+
 2010-08-08  Adam Barth  <abarth@webkit.org>
 

trunk/WebCore/html/HTMLAnchorElement.cpp

@@ -238 +238 @@
             // this link
             case EditableLinkLiveWhenNotFocused:
-                if (down && document()->frame() && document()->frame()->selection() &&
-                    document()->frame()->selection()->rootEditableElement() == rootEditableElement())
+                if (down && document()->frame() && document()->frame()->selection()->rootEditableElement() == rootEditableElement())
                     return;
                 break;