Changeset 64954 in webkit


Ignore:
Timestamp:
Aug 8, 2010 12:29:54 PM (14 years ago)
Author:
jamesr@google.com
Message:

2010-08-08 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

Set the shouldLazyAttach flag to true in the tree builder's adoption agency algorithm
​https://bugs.webkit.org/show_bug.cgi?id=43610

Sets the shouldLazyAttach flag to true for appendChild() calls inside the HTML tree
builder's adoption agency flag. This is a speedup assuming that nodes subjected
to the adoption agency are likely to be frequently reparented, and thus it is better
to delay creating the render tree until later (when hopefully the DOM is finalized).

On my mac pro this speeds up fast/parser/residual-style-hang.html by 2.6X.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

2010-08-08 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

Set the shouldLazyAttach flag to true in the tree builder's adoption agency algorithm
​https://bugs.webkit.org/show_bug.cgi?id=43610

New baselines for tests where the render tree depends on 0x0 render objects being
created/destroyed during adoption agency fixups.

  • platform/mac/fast/forms/formmove3-expected.txt:
  • platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/mac/fast/invalid/003-expected.txt:
  • platform/mac/fast/invalid/019-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug647-expected.txt:
  • platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
Location:
trunk
Files:
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r64953 r64954  
     12010-08-08  James Robinson  <jamesr@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Set the shouldLazyAttach flag to true in the tree builder's adoption agency algorithm
     6        https://bugs.webkit.org/show_bug.cgi?id=43610
     7
     8        New baselines for tests where the render tree depends on 0x0 render objects being
     9        created/destroyed during adoption agency fixups.
     10
     11        * platform/mac/fast/forms/formmove3-expected.txt:
     12        * platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
     13        * platform/mac/fast/invalid/003-expected.txt:
     14        * platform/mac/fast/invalid/019-expected.txt:
     15        * platform/mac/tables/mozilla/bugs/bug647-expected.txt:
     16        * platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
     17
    1182010-08-08  Mihai Parparita  <mihaip@chromium.org>
    219

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r64896 r64954  
    112112
    113113BUG36539 SLOW : http/tests/misc/uncacheable-script-repeated.html = PASS
    114 
    115 BUG47937 WIN DEBUG SLOW : fast/parser/residual-style-hang.html = PASS
    116114
    117115// -----------------------------------------------------------------
    … …  
    31733171BUGWK43543 : http/tests/misc/isindex-formdata.html = TIMEOUT
    31743172BUGWK43543 : http/tests/misc/isindex-with-no-form-base-href.html = TEXT TIMEOUT
    3175 BUGWK43543 DEBUG : fast/parser/residual-style-dom.html = TIMEOUT
    3176 BUGWK43543 LINUX MAC DEBUG : fast/parser/residual-style-hang.html = TIMEOUT
    31773173
    31783174BUGPFELDMAN WIN : http/tests/inspector-enabled/console-log-before-frame-navigation.html = TEXT
     3175
     3176// Need rebaselines due to landing of bug 43610
     3177BUGJAMESR WIN LINUX : fast/forms/formmove3-expected.txt = TEXT
     3178BUGJAMESR WIN LINUX : fast/forms/preserveFormDuringResidualStyle-expected.txt = TEXT
     3179BUGJAMESR WIN LINUX : fast/invalid/003-expected.txt = TEXT
     3180BUGJAMESR WIN LINUX : fast/invalid/019-expected.txt = TEXT
     3181BUGJAMESR WIN LINUX : tables/mozilla/bugs/bug647-expected.txt = TEXT
     3182BUGJAMESR WIN LINUX : tables/mozilla/other/wa_table_tr_align-expected.txt = TEXT
    31793183
    31803184// Failure caused by r64749

  • trunk/LayoutTests/platform/gtk/Skipped

    r64852 r64954  
    58635863editing/selection/5195166-1.html
    58645864
    5865 # Times out.  We need to figure out whether this is just caused by a slow bot
    5866 # or if there's a real bug here.
    5867 # https://bugs.webkit.org/show_bug.cgi?id=43540
    5868 fast/parser/residual-style-hang.html
    5869 
    58705865# Remaining Sputnik failures
    58715866# https://bugs.webkit.org/show_bug.cgi?id=43568

  • trunk/LayoutTests/platform/mac/fast/forms/formmove3-expected.txt

    r64712 r64954  
    3131          RenderText {#text} at (0,0) size 0x0
    3232      RenderBlock (anonymous) at (0,28) size 784x18
     33        RenderText {#text} at (0,0) size 0x0
    3334        RenderText {#text} at (0,0) size 104x18
    3435          text run at (0,0) width 104: "Form did submit"

  • trunk/LayoutTests/platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt

    r64712 r64954  
    2727          RenderInline {FONT} at (0,0) size 0x0
    2828          RenderText {#text} at (0,0) size 0x0
     29      RenderBlock (anonymous) at (0,25) size 784x0
     30        RenderText {#text} at (0,0) size 0x0
    2931      RenderBlock {DIV} at (0,25) size 784x36
    3032        RenderText {#text} at (0,0) size 775x36

  • trunk/LayoutTests/platform/mac/fast/invalid/003-expected.txt

    r25970 r64954  
    4444        RenderInline {FONT} at (0,0) size 0x0 [color=#FF0000]
    4545          RenderInline {I} at (0,0) size 0x0
    46       RenderBlock (anonymous) at (0,136) size 784x0 [color=#FF0000]
    47       RenderBlock (anonymous) at (0,136) size 784x0
    48         RenderInline {FONT} at (0,0) size 0x0 [color=#FF0000]
    4946      RenderBlock {P} at (0,136) size 784x18
    5047        RenderInline {FONT} at (0,0) size 123x18 [color=#FF0000]
    … …  
    5754          text run at (123,0) width 126: " I should not be red."
    5855      RenderBlock (anonymous) at (0,170) size 784x18
     56        RenderText {#text} at (0,0) size 0x0
    5957        RenderInline {B} at (0,0) size 131x18
    6058          RenderText {#text} at (0,0) size 36x18

  • trunk/LayoutTests/platform/mac/fast/invalid/019-expected.txt

    r64712 r64954  
    1111        RenderInline {B} at (0,0) size 0x0
    1212          RenderInline {NOBR} at (0,0) size 0x0
    13       RenderBlock (anonymous) at (0,0) size 784x0
    14       RenderBlock (anonymous) at (0,0) size 784x0
    15         RenderInline {B} at (0,0) size 0x0
    1613      RenderBlock {DIV} at (0,0) size 784x64
    1714        RenderBlock (anonymous) at (0,0) size 784x36

  • trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug647-expected.txt

    r30635 r64954  
    2727                              text run at (33,0) width 24: "inside"
    2828                          RenderText {#text} at (0,0) size 0x0
     29                        RenderBlock (anonymous) at (2,15) size 90x0
     30                          RenderText {#text} at (0,0) size 0x0
    2931                RenderBlock (anonymous) at (0,23) size 100x18
    3032                  RenderText {#text} at (10,0) size 79x18

  • trunk/LayoutTests/platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt

    r64712 r64954  
    239239                  RenderInline {B} at (0,0) size 0x0
    240240                    RenderInline {FONT} at (0,0) size 0x0 [color=#FF0000]
    241                 RenderBlock (anonymous) at (2,56) size 336x0
    242                 RenderBlock (anonymous) at (2,56) size 336x0
    243                   RenderInline {B} at (0,0) size 0x0
    244241                RenderBlock {P} at (2,72) size 336x0
    245242                  RenderInline {B} at (0,0) size 0x0
    … …  
    290287                  RenderInline {B} at (0,0) size 0x0
    291288                    RenderInline {FONT} at (0,0) size 0x0 [color=#FF0000]
    292                 RenderBlock (anonymous) at (2,56) size 336x0
    293                 RenderBlock (anonymous) at (2,56) size 336x0
    294                   RenderInline {B} at (0,0) size 0x0
    295289                RenderBlock {P} at (2,72) size 336x0
    296290                  RenderInline {B} at (0,0) size 0x0

  • trunk/WebCore/ChangeLog

    r64952 r64954  
     12010-08-08  James Robinson  <jamesr@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Set the shouldLazyAttach flag to true in the tree builder's adoption agency algorithm
     6        https://bugs.webkit.org/show_bug.cgi?id=43610
     7
     8        Sets the shouldLazyAttach flag to true for appendChild() calls inside the HTML tree
     9        builder's adoption agency flag.  This is a speedup assuming that nodes subjected
     10        to the adoption agency are likely to be frequently reparented, and thus it is better
     11        to delay creating the render tree until later (when hopefully the DOM is finalized).
     12
     13        On my mac pro this speeds up fast/parser/residual-style-hang.html by 2.6X.
     14
     15        * html/HTMLTreeBuilder.cpp:
     16        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
     17
    1182010-08-08  Nikita Vasilyev  <me@elv1s.ru>
    219

  • trunk/WebCore/html/HTMLTreeBuilder.cpp

    r64913 r64954  
    17171717            // Use appendChild instead of parserAddChild to handle possible reparenting.
    17181718            ExceptionCode ec;
    1719             node->element()->appendChild(lastNode->element(), ec);
     1719            node->element()->appendChild(lastNode->element(), ec, true);
    17201720            ASSERT(!ec);
    17211721            // 6.7
    … …  
    17321732        else {
    17331733            ExceptionCode ec;
    1734             commonAncestor->appendChild(lastNode->element(), ec);
     1734            commonAncestor->appendChild(lastNode->element(), ec, true);
    17351735            ASSERT(!ec);
    17361736        }
Note: See TracChangeset for help on using the changeset viewer.