Changeset 65060 in webkit

Timestamp:

Aug 10, 2010 2:05:22 AM (14 years ago)

Author:

hamaji@chromium.org

Message:

2010-08-10 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r64988.
​http://trac.webkit.org/changeset/64988
​https://bugs.webkit.org/show_bug.cgi?id=43775

"It seems to break chromium's ui_tests" (Requested by hamaji
on #webkit).

• public/WebFrameClient.h:
• src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebFrameClient.h (modified) (1 diff)
• src/FrameLoaderClientImpl.cpp (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-08-10  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r64988.
+        http://trac.webkit.org/changeset/64988
+        https://bugs.webkit.org/show_bug.cgi?id=43775
+
+        "It seems to break chromium's ui_tests" (Requested by hamaji
+        on #webkit).
+
+        * public/WebFrameClient.h:
+        * src/FrameLoaderClientImpl.cpp:
+        (WebKit::FrameLoaderClientImpl::detachedFromParent3):
+
 2010-08-10  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/WebKit/chromium/public/WebFrameClient.h

@@ -91 +91 @@
     // General notifications -----------------------------------------------
 
-    // This frame has been detached from the view.
-    //
-    // FIXME: Do not use this in new code. Currently this is used by code in
-    // Chromium that errantly caches WebKit objects.
-    virtual void frameDetached(WebFrame*) { }
-
     // This frame is about to be closed.
     virtual void willClose(WebFrame*) { }

trunk/WebKit/chromium/src/FrameLoaderClientImpl.cpp

@@ -247 +247 @@
     // or crashes.
     m_webFrame->frame()->script()->proxy()->clearForClose();
-
-    // Alert the client that the frame is being detached. This is the last
-    // chance we have to communicate with the client.
-    m_webFrame->client()->frameDetached(m_webFrame);
-
+    
     // Stop communicating with the WebFrameClient at this point since we are no
     // longer associated with the Page.