Changeset 65061 in webkit

Timestamp:

Aug 10, 2010 2:26:25 AM (14 years ago)

Author:

tkent@chromium.org

Message:

Fix crashes by SelectionController::modify().
​https://bugs.webkit.org/show_bug.cgi?id=43032

Reviewed by Darin Adler.

WebCore:

Test: editing/selection/selection-modify-crash.html

• editing/visible_units.cpp:

(WebCore::endOfDocument): Add NULL-check for document()->documentElement().

LayoutTests:

• editing/selection/selection-modify-crash-expected.txt: Added.
• editing/selection/selection-modify-crash.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/selection/selection-modify-crash-expected.txt (added)
• LayoutTests/editing/selection/selection-modify-crash.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/editing/visible_units.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-08-10  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Fix crashes by SelectionController::modify().
+        https://bugs.webkit.org/show_bug.cgi?id=43032
+
+        * editing/selection/selection-modify-crash-expected.txt: Added.
+        * editing/selection/selection-modify-crash.html: Added.
+
 2010-08-09  Eric Seidel  <eric@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-08-10  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Fix crashes by SelectionController::modify().
+        https://bugs.webkit.org/show_bug.cgi?id=43032
+
+        Test: editing/selection/selection-modify-crash.html
+
+        * editing/visible_units.cpp:
+        (WebCore::endOfDocument): Add NULL-check for document()->documentElement().
+
 2010-08-10  Dirk Schulze  <krit@webkit.org>
 

trunk/WebCore/editing/visible_units.cpp

@@ -1002 +1002 @@
 VisiblePosition endOfDocument(const Node* node)
 {
-    if (!node || !node->document())
+    if (!node || !node->document() || !node->document()->documentElement())
         return VisiblePosition();