Changeset 65211 in webkit

Timestamp:

Aug 11, 2010 7:37:44 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-08-11 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer
​https://bugs.webkit.org/show_bug.cgi?id=40725

Qt and Tiger seem to have encoding problems that swallow the --
characters that terminate the comment. We can avoid those problems by
inserting a space before the -->. We're losing coverage of these
issues, but I'm not sure we should be in the business of debugging
these encoders unless there's a security problem.

Thanks to ap for investigating and finding this workaround.

• fast/encoding/japanese-encoding-mix.html:
• platform/mac-tiger/Skipped:
• platform/qt/Skipped:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/encoding/japanese-encoding-mix.html (modified) (1 diff)
• platform/mac-tiger/Skipped (modified) (1 diff)
• platform/qt/Skipped (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-08-11  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer
+        https://bugs.webkit.org/show_bug.cgi?id=40725
+
+        Qt and Tiger seem to have encoding problems that swallow the --
+        characters that terminate the comment.  We can avoid those problems by
+        inserting a space before the -->.  We're losing coverage of these
+        issues, but I'm not sure we should be in the business of debugging
+        these encoders unless there's a security problem.
+
+        Thanks to ap for investigating and finding this workaround.
+
+        * fast/encoding/japanese-encoding-mix.html:
+        * platform/mac-tiger/Skipped:
+        * platform/qt/Skipped:
+
 2010-08-11  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/LayoutTests/fast/encoding/japanese-encoding-mix.html

@@ -3 +3 @@
 <meta http-equiv="Content-Type" content="text/html; charset=EUC-JP">
 <p>Some text here is encoded as EUC-JP, and some (in comment) as Shift_JIS. Since there is an explicit encoding declaration, auto-detection shouldn't change the encoding.</p><p>¥Ë¥Ã¥Ý¥ó¥Æ¥ì¥Ó</p>
-<!--‰EƒJƒ‰ƒ€ƒRƒƒ“ƒgƒAƒEƒg ‚±‚±‚©‚ç-->
+<!--‰EƒJƒ‰ƒ€ƒRƒƒ“ƒgƒAƒEƒg ‚±‚±‚©‚ç -->
 <script>
 if (window.layoutTestController)

trunk/LayoutTests/platform/mac-tiger/Skipped

@@ -200 +200 @@
 http/tests/inspector/resource-parameters.html
 
-# Tiger's TextDecoder doesn't correctly pass --> to the HTML Parser
-# at the end of a Shift_JIS comment, causing this test to fail.
-# https://bugs.webkit.org/show_bug.cgi?id=40725
-fast/encoding/japanese-encoding-mix.html
-
 # New modal dialog tests fail on Tiger.
 # Tests introduced in http://trac.webkit.org/changeset/61599.

trunk/LayoutTests/platform/qt/Skipped

@@ -5374 +5374 @@
 fast/dom/HTMLLinkElement/prefetch.html
 
-# Failing after enabling HTML5 parser in r61234
-# https://bugs.webkit.org/show_bug.cgi?id=40661
-fast/encoding/japanese-encoding-mix.html
-
 # https://bugs.webkit.org/show_bug.cgi?id=35350
 fast/events/show-modal-dialog-onblur-onfocus.html