Changeset 65260 in webkit

Timestamp:

Aug 12, 2010 11:22:34 AM (14 years ago)

Author:

loki@webkit.org

Message:

2010-08-12 Gabor Loki <​loki@webkit.org>

Reviewed by Geoffrey Garen.

Fix the array subscript is above array bounds warning in ByteArray on ARM.
​https://bugs.webkit.org/show_bug.cgi?id=43358

The warning is very similar to this one: ​http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37861

• wtf/ByteArray.cpp: (WTF::ByteArray::create):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/ByteArray.cpp (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-08-12  Gabor Loki  <loki@webkit.org>
+
+        Reviewed by Geoffrey Garen.
+
+        Fix the array subscript is above array bounds warning in ByteArray on ARM.
+        https://bugs.webkit.org/show_bug.cgi?id=43358
+
+        The warning is very similar to this one: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37861
+
+        * wtf/ByteArray.cpp:
+        (WTF::ByteArray::create):
+
 2010-08-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 

trunk/JavaScriptCore/wtf/ByteArray.cpp

@@ -26 +26 @@
 #include "config.h"
 #include "ByteArray.h"
+#include "StdLibExtras.h"
 
 namespace WTF {
@@ -31 +32 @@
 PassRefPtr<ByteArray> ByteArray::create(size_t size)
 {
-    unsigned char* buffer = new unsigned char[size + sizeof(ByteArray) - sizeof(size_t)];
+    unsigned char* buffer = new unsigned char[size + OBJECT_OFFSETOF(ByteArray, m_data)];
     ASSERT((reinterpret_cast<size_t>(buffer) & 3) == 0);
     return adoptRef(new (buffer) ByteArray(size));