Changeset 65390 in webkit


Ignore:
Timestamp:
Aug 15, 2010 6:58:15 PM (14 years ago)
Author:
jhoneycutt@apple.com
Message:

WebEditorClient::didBeginEditing is never called in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=42939

Reviewed by Sam Weinig.

  • WebKitTestRunner/PlatformWebView.h:

Declare focus().

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
Focus the PlatformWebView.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::focus):
Stubbed.

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::focus):
Focus the view.

Location:
trunk/WebKitTools
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r65389 r65390  
     12010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
     2
     3        WebEditorClient::didBeginEditing is never called in WebKit2
     4        https://bugs.webkit.org/show_bug.cgi?id=42939
     5
     6        Reviewed by Sam Weinig.
     7
     8        * WebKitTestRunner/PlatformWebView.h:
     9        Declare focus().
     10
     11        * WebKitTestRunner/TestController.cpp:
     12        (WTR::TestController::resetStateToConsistentValues):
     13        Focus the PlatformWebView.
     14
     15        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
     16        (WTR::PlatformWebView::focus):
     17        Stubbed.
     18
     19        * WebKitTestRunner/win/PlatformWebViewWin.cpp:
     20        (WTR::PlatformWebView::focus):
     21        Focus the view.
     22
    1232010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
    224

  • trunk/WebKitTools/WebKitTestRunner/PlatformWebView.h

    r63155 r65390  
    5252    PlatformWKView platformView() { return m_view; }
    5353    void resizeTo(unsigned width, unsigned height);
     54    void focus();
    5455
    5556private:

  • trunk/WebKitTools/WebKitTestRunner/TestController.cpp

    r65274 r65390  
    184184    WKPreferencesSetFontSmoothingLevel(preferences, kWKFontSmoothingLevelNoSubpixelAntiAliasing);
    185185
     186    m_mainWebView->focus();
     187
    186188    // Reset main page back to about:blank
    187189    m_doneResetting = false;

  • trunk/WebKitTools/WebKitTestRunner/mac/PlatformWebViewMac.mm

    r64485 r65390  
    5959}
    6060
     61void PlatformWebView::focus()
     62{
     63    // Implement.
     64}
     65
    6166} // namespace WTR

  • trunk/WebKitTools/WebKitTestRunner/win/PlatformWebViewWin.cpp

    r65294 r65390  
    7474}
    7575
     76void PlatformWebView::focus()
     77{
     78    ::SetFocus(::WKViewGetWindow(m_view));
     79}
     80
    7681} // namespace WTR
Note: See TracChangeset for help on using the changeset viewer.