Changeset 65497 in webkit

Timestamp:

Aug 17, 2010 5:23:00 AM (14 years ago)

Author:

xan@webkit.org

Message:

2010-08-17 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Fix wrapping of core Events in the bindings
​https://bugs.webkit.org/show_bug.cgi?id=44095

Return the proper GObject type instead of hardcoding
WebKitDOMEvent for all Event types.

• bindings/gobject/GObjectEventListener.cpp: (WebCore::GObjectEventListener::handleEvent):
• bindings/gobject/WebKitDOMBinding.cpp: (WebKit::kit):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/gobject/GObjectEventListener.cpp (modified) (2 diffs)
• bindings/gobject/WebKitDOMBinding.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-08-17  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Gustavo Noronha.
+
+        [GTK] Fix wrapping of core Events in the bindings
+        https://bugs.webkit.org/show_bug.cgi?id=44095
+
+        Return the proper GObject type instead of hardcoding
+        WebKitDOMEvent for all Event types.
+
+        * bindings/gobject/GObjectEventListener.cpp:
+        (WebCore::GObjectEventListener::handleEvent):
+        * bindings/gobject/WebKitDOMBinding.cpp:
+        (WebKit::kit):
+
 2010-08-17  Xan Lopez  <xlopez@igalia.com>
 

trunk/WebCore/bindings/gobject/GObjectEventListener.cpp

@@ -22 +22 @@
 #include "Event.h"
 #include "EventListener.h"
+#include "webkit/WebKitDOMEvent.h"
 #include "webkit/WebKitDOMEventPrivate.h"
 #include <wtf/HashMap.h>
@@ -31 +32 @@
 {
     gboolean handled = FALSE;
-    WebKitDOMEvent* gobjectEvent = WebKit::wrapEvent(event);
+    WebKitDOMEvent* gobjectEvent = WEBKIT_DOM_EVENT(WebKit::kit(event));
     g_signal_emit_by_name(m_object, m_signalName.utf8().data(), gobjectEvent, &handled);
 }

trunk/WebCore/bindings/gobject/WebKitDOMBinding.cpp

@@ -33 +33 @@
 #include "WebKitDOMDOMWindowPrivate.h"
 #include "WebKitDOMElementPrivate.h"
+#include "WebKitDOMEventPrivate.h"
 #include "WebKitDOMNode.h"
 #include "WebKitDOMNodePrivate.h"
@@ -141 +142 @@
         wrappedEvent = wrapUIEvent(static_cast<UIEvent*>(event));
     else
-        wrappedEvent = 0;
+        wrappedEvent = wrapEvent(event);
 
     return DOMObjectCache::put(event, wrappedEvent);