Changeset 65814 in webkit

Timestamp:

Aug 23, 2010 9:34:54 AM (14 years ago)

Author:

andreas.kling@nokia.com

Message:

2010-08-23 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

setAttributeNS() should throw NAMESPACE_ERR for prefixed qualifiedName with null namespace
​https://bugs.webkit.org/show_bug.cgi?id=44432

Test: fast/dom/setAttributeNS-prefix-and-null-namespace.html

• dom/Element.cpp: (WebCore::Element::setAttributeNS): Throw NAMESPACE_ERR if namespace is null and the qualifiedName has a prefix.

2010-08-23 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

setAttributeNS() should throw NAMESPACE_ERR for prefixed qualifiedName with null namespace
​https://bugs.webkit.org/show_bug.cgi?id=44432

• fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js: Added.
• fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt: Added.
• fast/dom/setAttributeNS-prefix-and-null-namespace.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js (added)
• LayoutTests/fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt (added)
• LayoutTests/fast/dom/setAttributeNS-prefix-and-null-namespace.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/Element.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-08-23  Andreas Kling  <andreas.kling@nokia.com>
+
+        Reviewed by Tor Arne Vestbø.
+
+        setAttributeNS() should throw NAMESPACE_ERR for prefixed qualifiedName with null namespace
+        https://bugs.webkit.org/show_bug.cgi?id=44432
+
+        * fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js: Added.
+        * fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt: Added.
+        * fast/dom/setAttributeNS-prefix-and-null-namespace.html: Added.
+
 2010-08-23  Hironori Bono  <hbono@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-08-23  Andreas Kling  <andreas.kling@nokia.com>
+
+        Reviewed by Tor Arne Vestbø.
+
+        setAttributeNS() should throw NAMESPACE_ERR for prefixed qualifiedName with null namespace
+        https://bugs.webkit.org/show_bug.cgi?id=44432
+
+        Test: fast/dom/setAttributeNS-prefix-and-null-namespace.html
+
+        * dom/Element.cpp:
+        (WebCore::Element::setAttributeNS): Throw NAMESPACE_ERR if namespace is null
+        and the qualifiedName has a prefix.
+
 2010-08-23  Ryuan Choi  <ryuan.choi@samsung.com>
 

trunk/WebCore/dom/Element.cpp

@@ -1214 +1214 @@
         return;
 
+    if (namespaceURI.isNull() && !prefix.isNull()) {
+        ec = NAMESPACE_ERR;
+        return;
+    }
+
     QualifiedName qName(prefix, localName, namespaceURI);